Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unified CRDs for FederatedObject and CollectedStatus #121

Merged
merged 1 commit into from
Jul 3, 2023
Merged

feat: unified CRDs for FederatedObject and CollectedStatus #121

merged 1 commit into from
Jul 3, 2023

Conversation

limhawjia
Copy link
Collaborator

@limhawjia limhawjia commented Jun 19, 2023 •
edited
Loading

Key changes:

  • Adds unified FederatedObject and ClusterFederatedObject types
  • Adds unified CollectedStatus and ClusterCollectedStatus types
  • Removes types API group and its corresponding packages
  • Update FederatedTypeConfig schema to only have a source type

@limhawjia limhawjia marked this pull request as draft June 19, 2023 04:54
@limhawjia limhawjia requested review from SOF3 and mrlihanbo June 19, 2023 05:21
@limhawjia limhawjia marked this pull request as ready for review June 19, 2023 05:29
SOF3
SOF3 requested changes Jun 19, 2023
View reviewed changes
pkg/apis/core/v1alpha1/extensions_federatedobject.go Outdated Show resolved Hide resolved
pkg/apis/core/v1alpha1/extensions_federatedobject.go Outdated Show resolved Hide resolved
pkg/apis/core/v1alpha1/extensions_federatedobject.go Outdated Show resolved Hide resolved
pkg/apis/core/v1alpha1/types_collectedstatus.go Outdated Show resolved Hide resolved
pkg/apis/core/v1alpha1/types_federatedobject.go Show resolved Hide resolved
@limhawjia limhawjia merged commit dc6f50a into kubewharf:refactor/unified-federated-type Jul 3, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrlihanbo mrlihanbo mrlihanbo left review comments

@SOF3 SOF3 SOF3 approved these changes

@gary-lgy gary-lgy gary-lgy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@limhawjia @SOF3 @gary-lgy @mrlihanbo