deps: Bump OpenTelemetryCollector to v1beta1 #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
viccuad
added a commit
to viccuad/helm-charts
that referenced
this pull request
Jul 25, 2024
This reverts commit 05a6207. This revert ought to fix the jaeger helm chart install error: ``` jaeger.jaegertracing.io/my-open-telemetry created Error: UPGRADE FAILED: failed to create resource: admission webhook "mopentelemetrycollectorbeta.kb.io" denied the request: json: cannot unmarshal string into Go struct field OpenTelemetryCollectorSpec.spec.config of type v1beta1.Config ``` There seems to be incompatibilities between latest jaeger-operator-2.54.0 (from 2024-06) and latest opentelemetry-operator-0.64.4. The latest opentelemetry-operator chart includes the operator image 0.103.0 but has not yet consumed 0.104.0, which performs the migrationg to OpentelemetryCollector apiVersion `opentelemetry.io/v1beta1`.
viccuad
added a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #474
Test
Tested by performing a manual helm upgrade over kubewarden with telemetry deployed using kubewarden-end-to-end-tests.
Additional Information
Tradeoff
Potential improvement