feat: Add HA settings to Rancher UI questions #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
jvanz
approved these changes
Apr 16, 2024
|
That is true, and I don't see any way to solve it. The chart json schema prevents installation though but it is ugly. I'm already using a trick by setting an unexsistent value |
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
|
Copied previous work into viccuad/prod-questions-archive. Will open issues against rancher/dashboard and link this PR. Rebased and dropped the buggy elements. Current state from this PR: Screencast_2024-04-16_15.47.12.webmScreencast_2024-04-16_15.48.18.webmReady for review. |
flavio
approved these changes
Apr 16, 2024
fabriziosestito
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
partially closes #418 (some features are blocked by UI bugs, see below).
Test
Tested manually. See videos also:
2024-04-16-11.28.33.202075928.mp4
2024-04-16-11.30.58.202011297.mp4
Additional Information
Changed name of sections, @kravciak this may mean changes to Kubewarden UI testsuite.
Tradeoff
Potential improvement
@aalves08 There are 2 UI bugs, unrelated to the questions.yaml changes:
type: yamldoesn't read and use the value of the variable from values.yaml as default.type: yamldoesn'd display correctly unless going to "Edit YAML" and back to "Edit Options"