Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ExtendedDataVolume #539

Open
bennyz opened this issue Aug 15, 2023 · 0 comments
Open

Drop ExtendedDataVolume #539

bennyz opened this issue Aug 15, 2023 · 0 comments

Comments

@bennyz
Copy link
Member

bennyz commented Aug 15, 2023

          I'm ok with having this fix as an easy solution for backporting, but the core issue here is that we retrieve the DVs using getDVs that return "our struct" but without setting the 'PVC' and so in some places we expect it to be set (when returned from ListVMs) and sometimes it's not.. and in addition, in most of the places we don't even use the two functions of "out struct".. maybe it will be a better idea to drop that struct as @liranr23 wrote above and replace the two methods with utility-methods, so that when "our struct" is returned, we can assume both the DV and the PVC were queried, wdyt?

Originally posted by @ahadas in #530 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant