Fix migration to remote cluster #1058
Open
+29
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1058 +/- ##
==========================================
- Coverage 16.33% 16.32% -0.02%
==========================================
Files 112 112
Lines 19771 19784 +13
==========================================
Hits 3229 3229
- Misses 16256 16269 +13
Partials 286 286
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue: During the refactoring I have enabled the server, via which we expose the virt-v2v gathered information to the controller, to both migraiton types. The flow is that we request all nessasry information form pod and then manually kill it from the controller. But right now we can't reuqest the server which are in remote clusters. Fix: Disable the server in the remote migrations. This will cause the pod to be terminated and the controller will check the pod status and will continue if the pod succeded. Note: Because of this we can't get the OS nor Firmware form the remote migrations. This should not be a large issue as we use them right now only for prefenrace in kubevirt. Signed-off-by: Martin Necas <[email protected]>
mnecas
force-pushed
the
fix_remote_migraitons
branch
from
fa48f09
to
cf77f51
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
During the refactoring I have enabled the server, via which we expose the virt-v2v gathered information to the controller, to both migraiton types. The flow is that we request all nessasry information form pod and then manually kill it from the controller. But right now we can't reuqest the server which are in remote clusters.
Fix:
Disable the server in the remote migrations. This will cause the pod to be terminated and the controller will check the pod status and will continue if the pod succeded.
Note:
Because of this we can't get the OS nor Firmware form the remote migrations. This should not be a large issue as we use them right now only for prefenrace in kubevirt.