Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Activate http-proxy-middleware secure flag in production, properly install CA cert instead #187

Closed
mturley opened this issue Nov 4, 2020 · 5 comments

Comments

@mturley
Copy link
Collaborator

mturley commented Nov 4, 2020

We turned off NodeJS TLS validation with this env in the Dockerfile in #186, just as was done in mig-ui, to avoid errors when logging in on some clusters. We should find a better solution.

@mturley
Copy link
Collaborator Author

mturley commented Nov 4, 2020

Equivalent in mig-ui: migtools/mig-ui#1055

@gildub
Copy link
Contributor

gildub commented Nov 13, 2020

This has now migrated to using secure flag for http-proxy-middleware.
See #214 for details.
The question remains to use secure: true for production.
Might not happen before post-beta though.
Adjusted title accordingly.

@gildub gildub added the post-beta Features to be added after the beta release. label Nov 13, 2020
@gildub gildub changed the title Revisit the NODE_TLS_REJECT_UNAUTHORIZED env variable, properly install CA cert instead Activate http-proxy-middleware secure flag in production, properly install CA cert instead Nov 13, 2020
@gildub gildub removed the post-beta Features to be added after the beta release. label Nov 13, 2020
@mturley
Copy link
Collaborator Author

mturley commented Nov 14, 2020

I forgot about this issue @gildub . I think we actually don't want to use secure at all. In prod, we won't need SSL at all because the internal URLS (http://*.local) don't use HTTPS. And in dev, we'd be forcing the browser to accept self-signed certs anyway, so unless we want to all install the CA cert in our dev environments I think we can safely just use secure: false for developing too (I could be convinced otherwise on that one though).

@gildub
Copy link
Contributor

gildub commented Nov 16, 2020

@mturley, all good then if we don't need SSL between the virt-ui pod and the backend.
Closing this one.

@gildub gildub closed this as completed Nov 16, 2020
@mturley
Copy link
Collaborator Author

mturley commented Nov 16, 2020

@gildub oops. We should listen to Fabien on this, not me :) #152 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants