Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed#4194:The maximum value of the slider conflicts with the input v… #4200

Closed
wants to merge 1 commit into from
Closed

fixed#4194:The maximum value of the slider conflicts with the input v… #4200

wants to merge 1 commit into from

Conversation

studyingwang23
Copy link
Contributor

…alue

What type of PR is this?

/kind bug

What this PR does / why we need it:

Keep the values of the input box consistent with those of the slider.

Which issue(s) this PR fixes:

Fixes #4194

Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

@ks-ci-bot
Copy link
Collaborator

@studyingwang23: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed labels Sep 25, 2023
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: studyingwang23
To complete the pull request process, please assign harrisonliu5 after the PR has been reviewed.
You can assign the PR to them by writing /assign @harrisonliu5 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2023
@ks-ci-bot
Copy link
Collaborator

Hi @studyingwang23. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@studyingwang23
Copy link
Contributor Author

/assign @harrisonliu5

@ks-ci-bot
Copy link
Collaborator

@studyingwang23: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@donniean donniean closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@harrisonliu5 harrisonliu5

Labels
do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test needs-rebase size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The maximum value of the slider conflicts with the input value.
4 participants
@studyingwang23 @ks-ci-bot @donniean @harrisonliu5