Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Provide an option for passing a config file for addon configure command. #20124

Open
omleteer opened this issue Dec 17, 2024 · 0 comments

Comments

@omleteer
Copy link

omleteer commented Dec 17, 2024

What Happened?

Currently when configuring addons with the command:

minikube addons configure <addon>

eg:

minikube addons configure registry-creds

The user is prompted to input the values one by one, eg:

Do you want to enable AWS Elastic Container Registry? [y/n]:

and so on.

Some times it easier to provide a config file containing so that the values can be read from this.

The request is for a "-c" local flag to the addon configure command, eg:

minikube addons configure registry-creds -c ~/.minikube/configs/registry-creds-config.json

An example of this file is:

{
  "enableAWSEcr": "enable",
  "awsEcrConfigs": {
     "awsAccessID": "changeme",
     "awsAccessKey": "changeme",
     "awsSessionToken": "changeme",
     "awsRegion": "changeme",
     "awsAccount": "changeme",
     "awsRole": "changeme"
  },
  "enableGCR": "disable",
  "gcrConfigs": {
     "gcrPath": "changeme",
     "gcrURL": "https://gcr.io"
  },
  "enableDockerRegistry": "disable",
  "dockerConfigs": {
     "dockerServer": "changeme",
     "dockerUser": "changeme",
     "dockerPass": "changeme"
  },
  "enableACR": "disable",
  "acrConfigs": {
     "acrURL": "changeme",
     "acrClientID": "changeme",
     "acrPassword": "changeme"
  }
}

The parsing of this config will be specific to the kind of addon. (Here we have chosen a naming style consistent with the style within the code itself, egcmd/minikube/cmd/config/configure.go, but we can adopt other stratgies here).

Also to consider:

  • Whether to have a single options file for all addons
  • [Preferred] addon specific options file - that MUST be passed to override default behavior always prompting.

Attach the log file

This is not an issue but a feature request.

Operating System

macOS (Default)

Driver

Docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant