Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: xhyve driver: Allow multiple Virtio9p and NFS mounts #1837

Closed
huguesalary opened this issue Aug 17, 2017 · 3 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@huguesalary
Copy link
Contributor

Feature request

OS: Mac OS X
Driver: xhyve

The xhyve driver just gained the ability to mount multiple Host folders inside the Guest virtual machine via Virtio9p (machine-drivers/docker-machine-driver-xhyve#194) or NFS (machine-drivers/docker-machine-driver-xhyve#121)

It would be great if minikube implemented those changes too.

I already wrote the code and submitted 2 PRs:

#1803 (NFS)
#1804 (Virtio9P)

Those 2 PRs allow the minikube user to mount Host folders inside the Guest. It introduces 4 new arguments: xhyve-nfs-share, xhyve-nfs-shares-root, xhyve-virtio-9p and xhyve-virtio-9p-root

Those arguments can be used as follow:

9p

  • Mount Host's /Users/ folder inside Guest, using 9p:
    minikube start --vm-driver=xhyve --xhyve-virtio-9p /Users

  • Mount Host's /Users/ folder and /some/other/folder inside Guest, using 9p:
    minikube start --vm-driver=xhyve --xhyve-virtio-9p /Users --xhyve-virtio-9p /some/other/folder

  • Mount Host's /Users/ folder and /some/other/folder inside Guest, at /my9pRoot, using 9p:
    minikube start --vm-driver=xhyve --xhyve-virtio-9p /Users --xhyve-virtio-9p /some/other/folder --xhyve-virtio-9p-root /my9pRoot

If --xhyve-virtio-9p-root is not specified, the folders will be mounted at /xhyve-virtio9p (xhyve's default)

NFS

  • Mount Host's /Users/ folder inside Guest, using NFS:
    minikube start --vm-driver=xhyve --xhyve-nfs-share /Users

  • Mount Host's /Users/ folder and /some/other/folder inside Guest, using NFS:
    minikube start --vm-driver=xhyve --xhyve-nfs-share /Users --xhyve-nfs-share /some/other/folder

  • Mount Host's /Users/ folder and /some/other/folder inside Guest, at /myNFSSharesRoot, using NFS:
    minikube start --vm-driver=xhyve --xhyve-nfs-share /Users --xhyve-nfs-share /some/other/folder --xhyve-nfs-shares-root /myNFSSharesRoot

If --xhyve-nfs-shares-root is not specified, the folders will be mounted at /xhyve-nfsshares (xhyve's default)

@huguesalary huguesalary changed the title xhyve driver: Allow multiple Virtio9p and NFS mounts Feature Request: xhyve driver: Allow multiple Virtio9p and NFS mounts Aug 22, 2017
@r2d4 r2d4 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 2, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 8, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants