Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate status.nodeInfo.kubeProxyVersion field #4004

Open
20 tasks done
HirazawaUi opened this issue May 15, 2023 · 48 comments
Open
20 tasks done

Deprecate status.nodeInfo.kubeProxyVersion field #4004

HirazawaUi opened this issue May 15, 2023 · 48 comments
Assignees
@danwinship @HirazawaUi
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone
v1.33

Comments

@HirazawaUi
Copy link
Contributor

HirazawaUi commented May 15, 2023 •
edited
Loading

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 15, 2023
@HirazawaUi
Copy link
Contributor Author

/sig node
/cc @danwinship
/assign

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 15, 2023
@HirazawaUi HirazawaUi mentioned this issue May 15, 2023
Merged
@HirazawaUi
Copy link
Contributor Author

/cc @thockin

@SergeyKanzhelev
Copy link
Member

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 26, 2023
@danwinship danwinship mentioned this issue Sep 11, 2023
Merged
@thockin thockin added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Sep 27, 2023
@thockin
Copy link
Member

thockin commented Sep 27, 2023

What the staus on this? Alpha in 29?

@HirazawaUi
Copy link
Contributor Author

What the staus on this? Alpha in 29?

Yes, we'll be in Alpha at v1.29

@SergeyKanzhelev
Copy link
Member

/milestone v1.29
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.28, v1.29 Sep 27, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 27, 2023
@npolshakova
Copy link

Hello @HirazawaUi 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as tracked for enhancement freeze 🚀 . Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@npolshakova npolshakova moved this to Tracked for Enhancements Freeze in 1.29 Enhancements Tracking Sep 27, 2023
@krol3
Copy link

krol3 commented Oct 2, 2023

Hi @HirazawaUi 👋, v1.29 Communication Release Team. I would like to check any plan about publication blogs related new features, removals, and deprecations for this release.

You need to open a PR placeholder in the website repository.
The deadline will be on Thursday 19th October 2023
Here the 1.29 Calendar

@HirazawaUi HirazawaUi mentioned this issue Oct 6, 2023
Merged
@HirazawaUi
Copy link
Contributor Author

Ok, I've opened a PR placeholder in the website repository, thanks for the tip!

@thockin thockin moved this to New in SIG Network KEPs Oct 10, 2023
@thockin thockin moved this from New to Alpha in SIG Network KEPs Oct 10, 2023
@thockin thockin moved this from Alpha to New in SIG Network KEPs Oct 10, 2023
@harshitasao
Copy link

Hi @HirazawaUi 👋, v1.29 Docs Shadow here
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

gardener-prow bot pushed a commit to gardener/gardener that referenced this issue Oct 5, 2024
@ialidzhikov
Support for Kubernetes v1.31 (#10472)
ea892e5 
* Allow instantiating v1.31 Kubernetes clients

* Update `README.md` and `docs/usage/supported_k8s_versions.md` for K8s 1.31

* Maintain added feature gates

```
./hack/compare-k8s-feature-gates.sh 1.30 1.31

Feature gates added in 1.31 compared to 1.30:
AllowDNSOnlyNodeCSR
AllowInsecureKubeletCertificateSigningRequests
AnonymousAuthConfigurableEndpoints
AuthorizeNodeWithSelectors
AuthorizeWithSelectors
ConcurrentWatchObjectDecode
CoordinatedLeaderElection
DRAControlPlaneController
DisableAllocatorDualWrite
ImageVolume
ReloadKubeletServerCertificateFile
ResilientWatchCacheInitialization
ResourceHealthStatus
SupplementalGroupsPolicy
WatchCacheInitializationPostStartHook
```

* Maintain removed feature gates

```
./hack/compare-k8s-feature-gates.sh 1.30 1.31

Feature gates removed in 1.31 compared to 1.30:
APIPriorityAndFairness
CSIMigrationRBD
CSINodeExpandSecret
ConsistentHTTPGetHandlers
CustomResourceValidationExpressions
DefaultHostNetworkHostPortsInPodTemplates
InTreePluginAWSUnregister
InTreePluginAzureDiskUnregister
InTreePluginAzureFileUnregister
InTreePluginGCEUnregister
InTreePluginOpenStackUnregister
InTreePluginRBDUnregister
InTreePluginvSphereUnregister
JobReadyPods
ReadWriteOncePod
ServiceNodePortStaticSubrange
SkipReadOnlyValidationGCE
```

* Maintain locked to default feature gates

```
./hack/compare-k8s-feature-gates.sh 1.30 1.31

Feature gates locked to default in 1.31 compared to 1.30:
AppArmor                                 Default:  true
AppArmorFields                           Default:  true
DevicePluginCDIDevices                   Default:  true
DisableCloudProviders                    Default:  true
DisableKubeletCloudCredentialProviders   Default:  true
ElasticIndexedJob                        Default:  true
JobPodFailurePolicy                      Default:  true
KubeProxyDrainingTerminatingNodes        Default:  true
LogarithmicScaleDown                     Default:  true
PDBUnhealthyPodEvictionPolicy            Default:  true
PersistentVolumeLastPhaseTransitionTime  Default:  true
PodDisruptionConditions                  Default:  true
StatefulSetStartOrdinal                  Default:  true
```

* Maintain admission plugins

```
./hack/compare-k8s-admission-plugins.sh 1.30 1.31

Admission plugins added in 1.31 compared to 1.30:

Admission plugins removed in 1.31 compared to 1.30:
PersistentVolumeLabel
```

* Maintain API groups

```
./hack/compare-k8s-api-groups.sh 1.30 1.31

Kubernetes API group versions added in 1.31 compared to 1.30:
coordination.k8s.io/v1alpha1
resource.k8s.io/v1alpha3

Kubernetes API GVRs added in 1.31 compared to 1.30:
coordination.k8s.io/v1alpha1/leasecandidates
networking.k8s.io/v1beta1/ipaddresses
networking.k8s.io/v1beta1/servicecidrs
resource.k8s.io/v1alpha3/deviceclasses
resource.k8s.io/v1alpha3/podschedulingcontexts
resource.k8s.io/v1alpha3/resourceclaims
resource.k8s.io/v1alpha3/resourceclaimtemplates
resource.k8s.io/v1alpha3/resourceslices
storage.k8s.io/v1beta1/volumeattributesclasses

Kubernetes API group versions removed in 1.31 compared to 1.30:
resource.k8s.io/v1alpha2

Kubernetes API GVRs removed in 1.31 compared to 1.30:
resource.k8s.io/v1alpha2/podschedulingcontexts
resource.k8s.io/v1alpha2/resourceclaimparameters
resource.k8s.io/v1alpha2/resourceclaims
resource.k8s.io/v1alpha2/resourceclaimtemplates
resource.k8s.io/v1alpha2/resourceclasses
resource.k8s.io/v1alpha2/resourceclassparameters
resource.k8s.io/v1alpha2/resourceslices
```

* Maintain kube-controller-manager controllers

```
./hack/compute-k8s-controllers.sh 1.30 1.31

kube-controller-manager controllers added in 1.31 compared to 1.30:
Added Controllers for API Group [networking/v1beta1]: service-cidr-controller
Added Controllers for API Group [resource/v1alpha3]: resourceclaim-controller

kube-controller-manager controllers removed in 1.31 compared to 1.30:
Removed Controllers for API Group [networking/v1alpha1]: service-cidr-controller
Removed Controllers for API Group [resource/v1alpha2]: resourceclaim-controller
```

* [no-op] Maintain copies of the DaemonSet controller's scheduling logic

* Add K8s 1.31 to the local CloudProfile

* tests: Don't check for Node's `.status field.nodeInfo.kubeProxyVersion` field

The `.status field.nodeInfo.kubeProxyVersion` is a lie since its initial introduction. The field is set by kubelet which cannot know the kube-proxy version or whether kube-proxy is running at all or not.
The `DisableNodeKubeProxyVersion` feature gate is enabled by default since K8s 1.31. The field is set to empty string in the Node status.
There is no added value in checking this field in the upgrade tests due to the reasons from above.

Ref kubernetes/enhancements#4004

* Add version constraints for K8s 1.31

* maintenance controller: Set `.spec.kubernetes.kubeAPIServer.oidcConfig.clientAuthentication=nil` when doing forceful update to K8s 1.31+

* maintenance controller: Move `kubernetes.kubelet.systemReserved` to `kubernetes.kubelet.kubeReserved` when doing forceful update to K8s 1.31+

* Nit: Use the KubeProxyEnabled helper func instead of duplicating the same logic

* Update the e2e tests section in `docs/development/new-kubernetes-version.md`

* Update provider extensions instructions in `docs/development/new-kubernetes-version.md`

* Remove unnecessary logic for the `KubeletCgroupDriverFromCRI` feature gate

Only the feature gate enablement is not enough the new auto-detection flow to be used. The feature depends on a new CRI API that will be present only in containerd 2.0+. Additionally, even if cgroup driver is specified and the new flow auto-detects another one from the CRI, it will ignore the specified cgroup driver and will use the auto-detected one.

* Default kubelet's and containerd's cgroup driver to `systemd` for K8s 1.31+

* Update the local Garden Kubernetes version to 1.31

* Nit: Do not log admission is being deployed on make gardener-extensions-down

* Order API groups alphabetically
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2024
@HirazawaUi
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2024
@danwinship
Copy link
Contributor

/remove-lifecycle stale
/label lead-opted-in
/milestone v1.33

per liggitt's earlier comment this can now become on-by-default in 1.33

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 14, 2025
@kannon92
Copy link
Contributor

@HirazawaUi could you update this feature description with the latest state?

Reading these comments I think the state is:

  • KEP for beta was merged. Implemented was done.
  • Implemented was reverted.
  • KEP is actually in alpha but the description says it is in beta and complete?

@haircommander haircommander moved this from Triage to Proposed for consideration in SIG Node 1.33 KEPs planning Jan 31, 2025
@HirazawaUi
Copy link
Contributor Author

@HirazawaUi could you update this feature description with the latest state?

Reading these comments I think the state is:

  • KEP for beta was merged. Implemented was done.
  • Implemented was reverted.
  • KEP is actually in alpha but the description says it is in beta and complete?

updated.

@jenshu
Copy link

jenshu commented Feb 4, 2025

Hello @HirazawaUi 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage stable (disabled) for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • I see you already have a PR open to update the kep.yaml and PRR file, so that just needs to be merged

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jenshu jenshu moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 4, 2025
@ffromani ffromani moved this from Proposed for consideration to Sig Node Consulting in SIG Node 1.33 KEPs planning Feb 5, 2025
@jenshu
Copy link

jenshu commented Feb 10, 2025

Hi @HirazawaUi , looks like the PR has merged, so you are all set for enhancements freeze

@jenshu jenshu moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 10, 2025
@haircommander haircommander moved this from Sig Node Consulting to Tracked in SIG Node 1.33 KEPs planning Feb 11, 2025
@haircommander haircommander moved this from Tracked to Sig Node Consulting in SIG Node 1.33 KEPs planning Feb 11, 2025
@michellengnx
Copy link

Hello @danwinship and @HirazawaUi 👋, v1.33 Docs Shadow here.
Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?
If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@rytswd
Copy link
Member

rytswd commented Mar 1, 2025

Hi @HirazawaUi 👋 -- this is Ryota (@rytswd) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@HirazawaUi
Copy link
Contributor Author

@rytswd This is a minor change so it doesn't require a blog post :)

@rytswd
Copy link
Member

rytswd commented Mar 2, 2025

Noted, thanks for the update, @HirazawaUi! 🎸

@jenshu
Copy link

jenshu commented Mar 3, 2025

Hey again @HirazawaUi 👋, v1.33 Enhancements team here.

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Per the issue description, these are all of the implementation (code-related) PRs for 1.33, some of which are not merged yet:

Please let me know (and keep the issue description updated) if there are any other PRs in k/k that we should track for this KEP, so that we can maintain accurate status.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as At risk for code freeze.

@jenshu jenshu moved this from Tracked for enhancements freeze to At risk for code freeze in 1.33 Enhancements Tracking Mar 3, 2025
@dipesh-rawat
Copy link
Member

Hi @HirazawaUi 👋, v1.33 Enhancements team here,

Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment #4004 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

@HirazawaUi
Copy link
Contributor Author

I’m working on getting the PR merged.

@dipesh-rawat
Copy link
Member

Hey @HirazawaUi 👋, 1.33 Enhancements team here,

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the 1.33 Code Freeze!

Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

@dipesh-rawat dipesh-rawat moved this from At risk for code freeze to Tracked for code freeze in 1.33 Enhancements Tracking Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danwinship danwinship

@HirazawaUi HirazawaUi

Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
1.29 Enhancements Tracking
Status: Tracked for Code Freeze
1.33 Enhancements Tracking
Status: Tracked for code freeze
SIG Network KEPs
Status: Alpha
SIG Node 1.33 KEPs planning
Status: Sig Node Consulting
1.31 Enhancements Tracking
Status: Tracked for Doc Freeze
SIG Node 1.32 KEPs planning
Status: Not for release
Milestone
v1.33
Development

No branches or pull requests