-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should this library use json-iterator? #17
Comments
sure! |
/assign json-iter does support case sensitive JSON. |
/kind feature |
You mean it can detect unknown keys in case-sensitive manner? |
yes. i have a PR in the works to enable json-iter. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
initial reaction was that there is no good justification for this change: |
Looks like there is desire to switch k/k away from json iter. It suggests using a fork of stdlib, that supports the missing valudation features. |
Kubernetes uses
github.com/json-iterator/go
instead ofencoding/json
, should this library switch also?The text was updated successfully, but these errors were encountered: