Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Prometheus Dependency from e2e Test Scaffolds in Kubebuilder #4527

Open
camilamacedo86 opened this issue Jan 26, 2025 · 1 comment · May be fixed by #4529
Open

Remove Prometheus Dependency from e2e Test Scaffolds in Kubebuilder #4527

camilamacedo86 opened this issue Jan 26, 2025 · 1 comment · May be fixed by #4529
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

The e2e test scaffolds provided by Kubebuilder currently include a Prometheus dependency. Specifically, they apply a ServiceMonitor as part of the e2e tests. While this was originally added to align with the default Prometheus integration that Kubebuilder validates in its own e2e tests, it does not provide substantial value for end-users and introduces unnecessary complexity.

Issues:

Unnecessary Dependency:

  • The dependency only checks if a ServiceMonitor is applied.
  • It does not consume or validate metrics.

Added Complexity:

  • Prometheus setup complicates the scaffolds.
  • Not essential for basic e2e testing.

Existing Validation:

  • Prometheus integration is already tested in Kubebuilder’s internal e2e tests.

Proposal:

Benefits:

  • Simplifies usage for end-users.
  • Reduces unnecessary dependencies.
  • Aligns scaffolds with practical, user-focused goals.

Extra Labels

No response

@camilamacedo86 camilamacedo86 added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 26, 2025
@anshuman-agarwala
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants