Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karpenter_ignored_pod_count is not put under a subsystem #1992

Closed
jonathan-innis opened this issue Feb 14, 2025 · 5 comments · Fixed by #2015
Closed

karpenter_ignored_pod_count is not put under a subsystem #1992

jonathan-innis opened this issue Feb 14, 2025 · 5 comments · Fixed by #2015
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jonathan-innis
Copy link
Member

Description

Observed Behavior:

Karpenter has an alpha metric called karpenter_ignored_pod_count which should be put in the scheduler namespace but wasn't

Expected Behavior:

This metric should be in the scheduler namespace and should be named karpenter_scheduler_ignored_pod_count to align with other metrics that we have about the count of pods that fail to schedule.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@jonathan-innis jonathan-innis added the kind/bug Categorizes issue or PR as related to a bug. label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 14, 2025
@jonathan-innis
Copy link
Member Author

/triage accepted
/good-first-issue
/help

@k8s-ci-robot
Copy link
Contributor

@jonathan-innis:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/triage accepted
/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 14, 2025
@olegy2008
Copy link
Contributor

Hi @jonathan-innis, I'm looking for something to contribute to. Do you mind if I work on this?

Just to clarify, you are asking to put ignored_pod_count under the scheduler subsystem, while keeping it under the karpenter namespace, so the name would be karpenter_scheduler_ignored_pod_count and that's it?

Because expected behavior section is a bit misleading since you are asking to put it under scheduler namespace.

@jonathan-innis
Copy link
Member Author

@olegy2008 Yep! You've got it

1 similar comment
@jonathan-innis
Copy link
Member Author

@olegy2008 Yep! You've got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants