Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod events controllers should use PodScheduled's lastTransitionTime to mark when pod events occur #1965

Open
jonathan-innis opened this issue Feb 5, 2025 · 7 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. performance Issues relating to performance (memory usage, cpu usage, timing) priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jonathan-innis
Copy link
Member

We use our in-memory view of the pod cache right now to mark that pods have been bound to nodes or that they have initiated deletion; however, this is just based on us seeing the events -- it would be nice if we could rely on pod status conditions for this information.

Also, with this change, we should remove our need to watch Create events when Karpenter first starts-up which currently removes the Consolidatable status condition across all NodeClaims across the board due to a reconciliation of the Pod being triggered on Create

@jonathan-innis
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 5, 2025
@jonathan-innis
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 5, 2025
@jonathan-innis jonathan-innis added the performance Issues relating to performance (memory usage, cpu usage, timing) label Feb 6, 2025
@jonathan-innis
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@jonathan-innis:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 13, 2025
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Feb 13, 2025
@jonathan-innis
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 13, 2025
@flavono123
Copy link
Contributor

/assign

@flavono123
Copy link
Contributor

flavono123 commented Feb 21, 2025

to clarify the requirement, the cache field, NodeClaimStatus.LastPodEventTime should be deleted right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. performance Issues relating to performance (memory usage, cpu usage, timing) priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants