OCI image builds fail in goss on OS_VERSION key missing

[eshneken]

Environment

• Make target: make build-oci-ubuntu-2204
• Run using container image? (Y/N): N
• Environment vars:

OCI_TENANCY_ID=ocid1.tenancy.oc1..xxxy
OCI_USER_ID=ocid1.user.oc1..yyyy
OCI_CREDENTIALS_FINGERPRINT=aa:bb:cc:dd:ee
OCI_REGION=us-ashburn-1
OCI_CREDENTIALS_PASSPHRASE=
OCI_CREDENTIALS_KEY_B64=abcdefghijklmnop

• Vars file:

{
  "compartment_ocid": "ocid1.compartment.oc1..xxxx",
  "subnet_ocid": "ocid1.subnet.oc1.iad.yyyy",
  "availability_domain": "zzz:US-ASHBURN-AD-1"
}

What steps did you take and what happened?

Upon attempting to run the build for multiple targets (Oracle Linux 8, Ubuntu 2204, etc) the image build errors out and terminates without completion with error: oracle-oci: could not read json data in goss/goss-package.yaml: template: test:62:26: executing "test" at <.Vars.OS_VERSION>: map has no entry for key "OS_VERSION"

Previous versions would also report this error but would proceed with build and image creation. In the latest version, this error stops the build and an image never gets created.

What did you expect to happen?

Previous versions, specifically v0.1.30, also encountered this goss failure but continued on and eventually complete the image creation. The latest version of the image-builder always fails and never completes image creation.

Relevant log output

Log Output

==> oracle-oci: Running goss tests...
==> oracle-oci: Running GOSS render command: cd /tmp/goss &&  /tmp/goss-0.3.16-linux-amd64 --gossfile goss/goss.yaml --vars /tmp/goss/goss-vars.yaml --vars-inline '{"ARCH":"amd64","OS":"oracle linux","PROVIDER":"oci","containerd_version":"1.7.20","kubernetes_cni_deb_version":"","kubernetes_cni_rpm_version":"","kubernetes_cni_source_type":"pkg","kubernetes_cni_version":"1.2.0","kubernetes_deb_version":"1.30.5-1.1","kubernetes_rpm_version":"1.30.5","kubernetes_source_type":"pkg","kubernetes_version":"1.30.5"}' render > /tmp/goss-spec.yaml
==> oracle-oci: could not read json data in goss/goss-package.yaml: template: test:62:26: executing "test" at <.Vars.OS_VERSION>: map has no entry for key "OS_VERSION"

Anything else you would like to add?

---

/kind bug

[robo-cap]

You can use this image-builder/images/capi/packer/oci/packer.json file:

{
  "builders": [
    {
      "availability_domain": "{{user `availability_domain`}}",
      "base_image_filter": {
        "operating_system": "{{user `operating_system`}}",
        "operating_system_version": "{{user `operating_system_version`}}"
      },
      "base_image_ocid": "{{user `base_image_ocid`}}",
      "compartment_ocid": "{{user `compartment_ocid`}}",
      "fingerprint": "{{user `fingerprint`}}",
      "image_name": "cluster-api-{{user `build_name`}}-{{user `kubernetes_semver`}}-{{user `build_timestamp`}}",
      "key_file": "{{user `key_file`}}",
      "region": "{{user `region`}}",
      "shape": "{{user `shape`}}",
      "shape_config": {
        "ocpus": "{{user `ocpus`}}"
      },
      "ssh_private_key_file": "{{ user `ssh_private_key_file`}}",
      "ssh_username": "{{user `ssh_username`}}",
      "subnet_ocid": "{{user `subnet_ocid`}}",
      "tags": {
        "build_date": "{{isotime}}",
        "build_timestamp": "{{user `build_timestamp`}}",
        "containerd_version": "{{user `containerd_version`}}",
        "distribution": "{{user `operating_system`}}",
        "distribution_version": "{{user `operating_system_version`}}",
        "image_builder_version": "{{user `ib_version`}}",
        "kubernetes_cni_version": "{{user `kubernetes_cni_semver`}}",
        "kubernetes_version": "{{user `kubernetes_semver`}}"
      },
      "tenancy_ocid": "{{user `tenancy_ocid`}}",
      "type": "oracle-oci",
      "use_private_ip": "{{user `use_private_ip`}}",
      "user_data": "{{user `user_data`}}",
      "user_ocid": "{{user `user_ocid`}}"
    }
  ],
  "provisioners": [
    {
      "environment_vars": [
        "BUILD_NAME={{user `build_name`}}"
      ],
      "inline": [
        "if [ $BUILD_NAME != \"ubuntu-2004\" ]; then exit 0; fi",
        "while [ ! -f /var/lib/cloud/instance/boot-finished ]; do echo 'Waiting for cloud-init...'; sleep 1; done",
        "sudo apt-get -qq update && sudo DEBIAN_FRONTEND=noninteractive apt-get -qqy install python python-pip"
      ],
      "type": "shell"
    },
    {
      "ansible_env_vars": [
        "ANSIBLE_SSH_ARGS='{{user `existing_ansible_ssh_args`}} {{user `ansible_common_ssh_args`}}'"
      ],
      "extra_arguments": [
        "--extra-vars",
        "{{user `ansible_common_vars`}}",
        "--extra-vars",
        "{{user `ansible_extra_vars`}}",
        "--extra-vars",
        "{{user `ansible_user_vars`}}"
      ],
      "playbook_file": "./ansible/node.yml",
      "type": "ansible"
    },
    {
      "arch": "{{user `goss_arch`}}",
      "download_path": "{{user `goss_download_path`}}",
      "format": "{{user `goss_format`}}",
      "format_options": "{{user `goss_format_options`}}",
      "goss_file": "{{user `goss_entry_file`}}",
      "inspect": "{{user `goss_inspect_mode`}}",
      "remote_folder": "{{user `goss_remote_folder`}}",
      "remote_path": "{{user `goss_remote_path`}}",
      "skip_install": "{{user `goss_skip_install`}}",
      "tests": [
        "{{user `goss_tests_dir`}}"
      ],
      "type": "goss",
      "url": "{{user `goss_url`}}",
      "use_sudo": true,
      "vars_file": "{{user `goss_vars_file`}}",
      "vars_inline": {
        "ARCH": "amd64",
        "OS": "{{user `distribution` | lower }}",
        "OS_VERSION": "{{user `distro_version` | lower}}",
        "PROVIDER": "oci",
        "containerd_version": "{{user `containerd_version`}}",
        "kubernetes_cni_deb_version": "{{ user `kubernetes_cni_deb_version` }}",
        "kubernetes_cni_rpm_version": "{{ split (user `kubernetes_cni_rpm_version`) \"-\" 0 }}",
        "kubernetes_cni_source_type": "{{user `kubernetes_cni_source_type`}}",
        "kubernetes_cni_version": "{{user `kubernetes_cni_semver` | replace \"v\" \"\" 1}}",
        "kubernetes_deb_version": "{{ user `kubernetes_deb_version` }}",
        "kubernetes_rpm_version": "{{ split (user `kubernetes_rpm_version`) \"-\" 0 }}",
        "kubernetes_source_type": "{{user `kubernetes_source_type`}}",
        "kubernetes_version": "{{user `kubernetes_semver` | replace \"v\" \"\" 1}}"
      },
      "version": "{{user `goss_version`}}"
    }
  ],
  "variables": {
    "ansible_common_vars": "",
    "ansible_extra_vars": "",
    "ansible_user_vars": "",
    "availability_domain": "{{env `OCI_AVAILABILITY_DOMAIN`}}",
    "base_image_ocid": "",
    "build_timestamp": "{{timestamp}}",
    "compartment_ocid": "",
    "containerd_gvisor_runtime": "false",
    "containerd_gvisor_version": "latest",
    "containerd_sha256": null,
    "containerd_url": "https://github.com/containerd/containerd/releases/download/v{{user `containerd_version`}}/cri-containerd-cni-{{user `containerd_version`}}-linux-amd64.tar.gz",
    "containerd_version": null,
    "crictl_url": "https://github.com/kubernetes-sigs/cri-tools/releases/download/v{{user `crictl_version`}}/crictl-v{{user `crictl_version`}}-linux-amd64.tar.gz",
    "crictl_version": null,
    "disable_default_service_account": "",
    "encrypted": "false",
    "existing_ansible_ssh_args": "{{env `ANSIBLE_SSH_ARGS`}}",
    "fingerprint": "{{env `OCI_USER_FINGERPRINT`}}",
    "ib_version": "{{env `IB_VERSION`}}",
    "key_file": "{{env `OCI_USER_KEY_FILE`}}",
    "kubernetes_cni_deb_version": null,
    "kubernetes_cni_http_source": null,
    "kubernetes_cni_rpm_version": null,
    "kubernetes_cni_semver": null,
    "kubernetes_cni_source_type": null,
    "kubernetes_container_registry": null,
    "kubernetes_deb_gpg_key": null,
    "kubernetes_deb_repo": null,
    "kubernetes_deb_version": null,
    "kubernetes_http_source": null,
    "kubernetes_load_additional_imgs": null,
    "kubernetes_rpm_gpg_check": null,
    "kubernetes_rpm_gpg_key": null,
    "kubernetes_rpm_repo": null,
    "kubernetes_rpm_version": null,
    "kubernetes_semver": null,
    "kubernetes_series": null,
    "kubernetes_source_type": null,
    "ocpus": "1",
    "operating_system": null,
    "operating_system_version": null,
    "region": "us-ashburn-1",
    "shape": "VM.Standard.E4.Flex",
    "ssh_private_key_file": "",
    "ssh_username": null,
    "subnet_ocid": "{{env `OCI_SUBNET_OCID`}}",
    "tenancy_ocid": "{{env `OCI_TENANCY_OCID`}}",
    "use_private_ip": "false",
    "user_data": "",
    "user_ocid": "{{env `OCI_USER_OCID`}}"
  }
}