-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow ManagerOptions to be marshalled #2926
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
It would be very nice if the ManagerOptions https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/manager/manager.go#L101 was more easily printable. Example use case: logging on startup to be sure of what config is used.
Using fmt.Sprintf("%#v", options) has been my workaround but it's pretty suboptimal (pointers not followed for example)
Currently using json.Marshal gives an error like
Failing to marshal this field named MapperProvider
I'd be willing to PR this, what I would do is add the struct tag
json:"-"
on fields that should not be printed / logged (e.g. MapperProvider) and then use the standardjson.Marshal
to get my human readable string.Wanted to gauge interest before making a PR
The text was updated successfully, but these errors were encountered: