Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes should not include the detail about release PR #10931

Closed
chandankumar4 opened this issue Jul 24, 2024 · 13 comments
Closed

Release notes should not include the detail about release PR #10931

chandankumar4 opened this issue Jul 24, 2024 · 13 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@chandankumar4
Copy link
Contributor

What steps did you take and what happened?

While generating the release notes, it should filter out the Release notes PR from it.

For example: This PR should not be a part of release notes.

What did you expect to happen?

It should filter out the release notes PR

Cluster API version

v1.8.0-beta.0

Kubernetes version

No response

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 24, 2024
@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 24, 2024
@rajankumary2k
Copy link
Contributor

Can I work on this Issue?

@chandankumar4
Copy link
Contributor Author

sure, Thanks
/assign @rajankumary2k

@chandankumar4
Copy link
Contributor Author

Feel free to ping me on slack or here if you need any more detail.

@rajankumary2k
Copy link
Contributor

Sure, Thanks!

@fabriziopandini fabriziopandini added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 31, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates an issue lacks a `priority/foo` label and requires one. label Jul 31, 2024
@fabriziopandini
Copy link
Member

Orthogonal consideration: Let's make sure to keep improving also documentation and test coverage for the release tool because those are super valuable for the next release team that will take a look at it

@chandankumar4
Copy link
Contributor Author

/assign chandankumar4
/unassign rajankumary2k

@chandankumar4
Copy link
Contributor Author

This issue got resolved itself, after updating the PR title from ":seedling:" to ":rocket:" for these three PRs 10440 10438 10439

@chandankumar4
Copy link
Contributor Author

Orthogonal consideration: Let's make sure to keep improving also documentation and test coverage for the release tool because those are super valuable for the next release team that will take a look at it

@fabriziopandini I Have opened up another issue for improving the test coverage.

@sbueringer
Copy link
Member

@chandankumar4 so everything should work as expected now, correct?

@chandankumar4
Copy link
Contributor Author

chandankumar4 commented Nov 4, 2024

@chandankumar4 so everything should work as expected now, correct?

Yes

@sbueringer
Copy link
Member

Thx!

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

Thx!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

No branches or pull requests

5 participants