Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore "delete all tags" steps in the AKS e2e tests #4212

Closed
nojnhuh opened this issue Nov 1, 2023 · 2 comments · Fixed by #4295
Closed

Restore "delete all tags" steps in the AKS e2e tests #4212

nojnhuh opened this issue Nov 1, 2023 · 2 comments · Fixed by #4295
Assignees
@nojnhuh
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
v1.13

Comments

@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 1, 2023

CAPZ's current version of ASO (v2.3.0) does not support deleting all tags from a ManagedCluster or ManagedClustersAgentPool, so those steps were removed from the e2e tests in test/e2e/aks_tags.go in #4069. They should be added back once CAPZ includes the next version of ASO which will support that use case (Azure/azure-service-operator#3367).

/area managedclusters
/kind cleanup
@k8s-ci-robot k8s-ci-robot added area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 1, 2023
@nojnhuh nojnhuh mentioned this issue Nov 1, 2023
Merged
4 tasks
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Nov 1, 2023

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 1, 2023
@nojnhuh nojnhuh moved this to Todo in CAPZ Planning Nov 1, 2023
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Nov 7, 2023

/assign

@dtzar dtzar modified the milestones: v1.12, next, v1.13 Nov 16, 2023
@nojnhuh nojnhuh linked a pull request Nov 21, 2023 that will close this issue
test deleting all tags, node labels, and node taints in AKS e2e #4295
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nojnhuh nojnhuh

Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
CAPZ Planning
Archived in project
Milestone
v1.13
Development

Successfully merging a pull request may close this issue.

test deleting all tags, node labels, and node taints in AKS e2e nojnhuh/cluster-api-provider-azure
3 participants
@dtzar @nojnhuh @k8s-ci-robot