Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow omitting the k8s patch version in azuremanagedcontrolplanes #4111

Closed
felfa01 opened this issue Oct 10, 2023 · 8 comments
Closed

Allow omitting the k8s patch version in azuremanagedcontrolplanes #4111

felfa01 opened this issue Oct 10, 2023 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Milestone

Comments

@felfa01
Copy link

felfa01 commented Oct 10, 2023

/kind feature

Describe the solution you'd like
AKS allows to omit the patch version and thus defaulting to latest patch. When trying to configure this via CAPZ the following error is thrown:

Error: admission webhook "validation.azuremanagedcontrolplanes.infrastructure.cluster.x-k8s.io" denied the request: must be a valid semantic version

Support docs: https://learn.microsoft.com/en-us/azure/aks/supported-kubernetes-versions?tabs=azure-cli#alias-minor-version

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 10, 2023
@dtzar
Copy link
Contributor

dtzar commented Oct 10, 2023

This is possible today in the current Go SDK we use as well as in ASO.
The problematic code is here.

Tagging @nojnhuh in case he wants to consider lighting this up in his PR.

@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 11, 2023

I think this would fit better as a change separate from #4069. This might be a bit more complicated than changing a regex since that value is currently shared in the templates between AzureManagedControlPlane spec.version and MachinePool spec.template.spec.version and I'm not sure if CAPI accepts MAJOR.MINOR versions there.

@LochanRn
Copy link
Member

@nojnhuh how do we support this if we want ?

Should I raise a support request in CAPI ?

@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 13, 2023

I think bringing this up in CAPI makes the most sense to me. That may have already been discussed at some point, so it would be worth a quick look through the CAPI issue queue, Slack, and weekly meeting notes to see if that has been previously brought up.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 29, 2024
@dtzar dtzar added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 29, 2024
@dtzar dtzar added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 9, 2024
@dtzar dtzar moved this to Todo in CAPZ Planning Mar 9, 2024
@dtzar dtzar added this to the next milestone Apr 4, 2024
@dtzar dtzar modified the milestones: next, v1.16 May 16, 2024
@dtzar dtzar added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 16, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented May 16, 2024

This is possible with the new ASO-based API: https://capz.sigs.k8s.io/topics/aso#experimental-aso-api

The way you would do this is to not specify spec.template.spec.version on the MachinePool, then set spec.orchestratorVersion to anything allowed by AKS on the ManagedClustersAgentPool definition in spec.resources for the AzureASOManagedMachinePool. orchestratorVersion would be set under this spec in the example template:

/close

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Closing this issue.

In response to this:

This is possible with the new ASO-based API: https://capz.sigs.k8s.io/topics/aso#experimental-aso-api

The way you would do this is to not specify spec.template.spec.version on the MachinePool, then set spec.orchestratorVersion to anything allowed by AKS on the ManagedClustersAgentPool definition in spec.resources for the AzureASOManagedMachinePool. orchestratorVersion would be set under this spec in the example template:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

No branches or pull requests

6 participants