Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shared tag value for AWS resource import #5020

Open
kahirokunn opened this issue Jun 13, 2024 · 3 comments
Open

Allow shared tag value for AWS resource import #5020

kahirokunn opened this issue Jun 13, 2024 · 3 comments
Labels
needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@kahirokunn
Copy link

Describe the solution you'd like
Currently, the implementation only supports the owned tag value for AWS resource imports. I would like to request that the shared tag value also be supported. This enhancement is important because creating resources with the owned tag leads to potential risks when the Cluster is deleted, as it attempts to delete the network associated with it. There is a risk that other services, such as Load Balancers or other deployments, could be relying on that network, leading to unintended disruptions.

Anything else you would like to add:
Allowing the shared tag value will provide greater flexibility and safety in managing AWS resources within shared environments. This change will help avoid accidental deletions of critical network infrastructure that might be shared across multiple services or applications.

Environment:

  • Cluster-api-provider-aws version: v2.5.0
  • Kubernetes version: (use kubectl version): v1.30.1
  • OS (e.g. from /etc/os-release): M1 MacOS
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 13, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2024
@kahirokunn
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants