Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting a Keycloak/Generic Provider #241

Open
vishalkuo opened this issue Jan 28, 2020 · 5 comments
Open

Supporting a Keycloak/Generic Provider #241

vishalkuo opened this issue Jan 28, 2020 · 5 comments

Comments

@vishalkuo
Copy link

We'd like to support keycloak (using OIDC) as a authn provider for our Guard setup. Is this something the team would accept as a PR / is there prior discussion around adding new providers that I should be aware of?

@tamalsaha
Copy link
Contributor

Thanks, @vishalkuo for opening the issue. For OIDC, what support in needed in Guard? I thought, you just need to configure kubectl properly:

https://kubernetes.io/docs/reference/access-authn-authz/authentication/#using-kubectl

@vishalkuo
Copy link
Author

I think we just want to manage all our authn via guard instead of dividing it between guard and the kubectl API. I'm not sure if there's another easier way to have all auth, including generic OIDC, go through guard.

@tamalsaha
Copy link
Contributor

Can you please outline the changes/additions needed in Guard?

@vishalkuo
Copy link
Author

I imagine what we'd want is a new provider here of type generic or keyclock. This provider would probably be similar to the google one as it'll verify claims and construct a authv1.UserInfo populated with the necessary user information.

@tamalsaha
Copy link
Contributor

Sounds good. If you want to open prs, you are welcome. Please note that you need to add e2e tests to make sure things work.

@vishalkuo vishalkuo changed the title Supporting Keycloak a Provider Supporting a Keycloak/Generic Provider Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants