Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparkOperator - Link to spark-rbac.yaml is broken #3892

Closed
vikas-saxena02 opened this issue Oct 3, 2024 · 5 comments
Closed

SparkOperator - Link to spark-rbac.yaml is broken #3892

vikas-saxena02 opened this issue Oct 3, 2024 · 5 comments

Comments

@vikas-saxena02
Copy link
Contributor

The link to create serviceAccount for driver pods in the Kubeflow Website is broken

In the Getting Started page for SparkOperator, there is a section on creating service account for driver pods which mentions the link to spark-rbac.yaml which no longer exists. The service accounts are now being dynamically created as per the templates in charts/spark-operator-chart/templates/spark/serviceaccount.yaml and charts/spark-operator-chart/templates/spark/rbac.yaml

I can think of two ways to fix this:

  1. Add the old spark-rbac.yaml under some path e.g. examples/spark
  2. Update the documentation with the naming convention for the new service accounts for driver pods

I am creating this issue here so that we can all land on a common solution.

@ha2hi
Copy link
Contributor

ha2hi commented Oct 3, 2024

Hi,

As you said, when we click spark-rbac.yaml in the docs, it says "page not found".

Recently I added it to the YAML file at that location.
And a PR for website modification has been sent.

@vikas-saxena02
Copy link
Contributor Author

Hi,

As you said, when we click spark-rbac.yaml in the docs, it says "page not found".

Recently I added it to the YAML file at that location. And a PR for website modification has been sent.

Awesome mate, Lets get your PR merged and thanks for the effort!!

@varodrig
Copy link
Contributor

PR merged. closing this issue, thanks @vikas-saxena02

@varodrig
Copy link
Contributor

/close

Copy link

@varodrig: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants