Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Namespace Filtering #4739

Closed
yanniszark opened this issue Nov 9, 2020 · 7 comments
Closed

[UI] Namespace Filtering #4739

yanniszark opened this issue Nov 9, 2020 · 7 comments
Labels
help wanted The community is welcome to contribute. kind/feature lifecycle/frozen

Comments

@yanniszark
Copy link
Contributor

yanniszark commented Nov 9, 2020

A common need that comes up when building a Kubernetes-based UI is a namespace selector.
Examples include the Kubeflow CentralDashboard.

How do we populate the namespace selector? How do we decide which namespaces the user can see?

The solution of kubeflow/dashboard#44 should be used for the KFP UI as well.

/cc @Bobgy @elikatsis @StefanoFioravanzo @vkoukis

@Bobgy
Copy link
Contributor

Bobgy commented Nov 9, 2020

I have been thinking about listing all namespaces in the cluster filtered by a pipelines label. If perf has limitation, then we need a cache.

I think specific actions need RBAC, seeing the list of namespaces probably don't.

@Bobgy
Copy link
Contributor

Bobgy commented Nov 9, 2020

When there are a lot of users, we might want to add UI features to search namespaces, marking a namespace as default and bookmark some namespaces.

@Bobgy Bobgy added kind/feature help wanted The community is welcome to contribute. labels Nov 15, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Feb 21, 2021

I propose the following:

On API side:

  1. update profile controller to add a pipelines.kubeflow.org/enabled: true label to Kubeflow namespaces
  2. add an endpoint in KFP API to list all namespaces with this label, return them as a response

On UI side:

  • Add a namespace selector that send a request to KFP API added above to get the list of namespaces, for the initial version, I think it can get all namespaces without pagination, and we add a search box to allow searching for namespaces.
  • Add namespace as a query parameter in KFP UI URI
  • The namespace selector persists namespace selected last time in local storage, so users won't need to select it each time.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 2, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Sep 12, 2021

/lifecycle frozen

@google-oss-robot google-oss-robot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Sep 12, 2021
@juliusvonkohout
Copy link
Member

/close

I think this is already implemented

Copy link

@juliusvonkohout: Closing this issue.

In response to this:

/close

I think this is already implemented

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The community is welcome to contribute. kind/feature lifecycle/frozen
Projects
None yet
Development

No branches or pull requests

4 participants