Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added cached layer for Go dependencies to Dockerfiles #11348

Merged

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Oct 31, 2024

Description of your changes:
This PR modifies the Dockerfiles to download dependencies earlier. That way the download layers can be cached and subsequent builds will be faster when dependencies don't change.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Oct 31, 2024
@hbelmiro hbelmiro changed the title Added cached layer for Go dependencies to Dockerfiles chore: Added cached layer for Go dependencies to Dockerfiles Nov 1, 2024
@hbelmiro hbelmiro marked this pull request as ready for review November 1, 2024 02:57
@VaniHaripriya
Copy link
Contributor

/lgtm

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HumairAK
Copy link
Collaborator

HumairAK commented Nov 5, 2024

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5dc43b6 into kubeflow:master Nov 5, 2024
15 checks passed
@hbelmiro hbelmiro deleted the cache-dependencies-on-images branch November 6, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed All CI tests on a pull request have passed lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants