Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] kfp-kubernetes ImagePullSecrets not working #11218

Open
ksgnextuple opened this issue Sep 17, 2024 · 3 comments
Open

[sdk] kfp-kubernetes ImagePullSecrets not working #11218

ksgnextuple opened this issue Sep 17, 2024 · 3 comments

Comments

@ksgnextuple
Copy link

Environment

  • KFP version: 1.8.0
  • KFP SDK version: kfp-2.7.0
  • All dependencies version:
    kfp                       2.7.0
    kfp-kubernetes            1.3.0
    kfp-pipeline-spec         0.3.0
    kfp-server-api            2.0.5

Getting the below error when using the set_image_pull_secrets function:

F0917 12:02:28.761279      17 main.go:76] KFP driver: failed to unmarshal Kubernetes config, error: unknown field "imagePullSecret" in kfp_kubernetes.KubernetesExecutorConfig

Impacted by this bug? Give it a 👍.

@Naegionn
Copy link

Naegionn commented Oct 22, 2024

Hi,
I am facing the same issue.
I found that suprisingly kfp-kubernetes did not support ImagePullSecrets initially.

My guess here is that older version of kfp-server-api do not support it as well but i am not aware of which version is required.

On my kubeflow installation with kf 1.8 and kfp-api 2.0 i get this error. On another installation kf=1.9 kfp-api=2.2 it is working.

I would think that ImagePullSecrets to allow pulling from private registries is one of the most common features.

@AxoyTO
Copy link

AxoyTO commented Oct 25, 2024

I have it deployed with versions: KFP Runtime 2.5.0, KFP SDK 2.7.0 and all other dependencies versions are the same. I don't face this issue.

@rimolive
Copy link
Member

ImagePullPolicy was added beginning KFP 2.0.5. See #10417 and #10416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants