Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump elliptic from 6.5.5 to 6.5.7 in /frontend #11127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 21, 2024

Bumps elliptic from 6.5.5 to 6.5.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.5 to 6.5.7.
- [Commits](indutny/elliptic@v6.5.5...v6.5.7)

---
updated-dependencies:
- dependency-name: elliptic
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 21, 2024
Copy link

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HumairAK
Copy link
Contributor

/lgtm
/approve

@hbelmiro
Copy link
Contributor

/ok-to-test
/hold there are failing tests

@HumairAK
Copy link
Contributor

@hbelmiro are those tests supposed to be passing? I see the front end integration tests passed, given it's a patch bump, I'd be surprised this is causing any legitimate failures.

@hbelmiro
Copy link
Contributor

@hbelmiro are those tests supposed to be passing? I see the front end integration tests passed, given it's a patch bump, I'd be surprised this is causing any legitimate failures.

@HumairAK it seems like @diegolovison found a flaky test. It may be this one.
@diegolovison can you confirm? If so, do you have a fix planned? Otherwise, we need to open an issue and maybe disable this test.

@diegolovison
Copy link
Contributor

I believe that's the one. In my opinion, we should rerun it until it passes and, rather than disabling it, work on fixing the issue.

@hbelmiro
Copy link
Contributor

rather than disabling it, work on fixing the issue.

Yeah, I mean disable it while it's not fixed. Or we can just rerun it.
Anyway, I created an issue: #11135

/rerun-all

@hbelmiro
Copy link
Contributor

/ok-to-test
/rerun-all

@hbelmiro
Copy link
Contributor

cc @zijianjoy

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file do-not-merge/hold javascript Pull requests that update Javascript code lgtm ok-to-test size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants