Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Update requests-toolbelt dependencies #10470

Open
alanhdu opened this issue Feb 12, 2024 · 12 comments
Open

[sdk] Update requests-toolbelt dependencies #10470

alanhdu opened this issue Feb 12, 2024 · 12 comments

Comments

@alanhdu
Copy link

alanhdu commented Feb 12, 2024

Currently, kfp pins requests-toolbelt < 1. Would it be possible to support requests-toolbelt=1.0? From the release notes, I doubt any of the breaking changes affect kfp.

w/o this, it becomes impossible to use kfp with other dependencies that require reuqests-toolbelt 1.0.

@rimolive
Copy link
Member

cc @connor-mccarthy

@chensun
Copy link
Member

chensun commented Mar 14, 2024

Please feel free to open a PR and validate through our presubmit test first.

Edit: @connor-mccarthy mentioned there might be an issue caused by some transitive dependency, but feel free to use a PR to revalidate it.

@SimonDR-Boltzmann
Copy link

SimonDR-Boltzmann commented Apr 29, 2024

This is affecting repositories with poetry as the new poetry 1.8.* requires requests-toolbelt>=1
I created a pr here: #10762 (disregard the failed attempts please 😬 )

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 29, 2024
Copy link

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@SimonDR-Boltzmann
Copy link

/reopen

Copy link

@SimonDR-Boltzmann: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SimonDR-Boltzmann
Copy link

Can this issue be reopened please? It is still causing dependency problems for us.

@gregsheremeta
Copy link
Contributor

/reopen

Copy link

@gregsheremeta: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot reopened this Aug 19, 2024
@github-actions github-actions bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Aug 20, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Oct 20, 2024
@rimolive
Copy link
Member

/lifecycle frozen

@google-oss-prow google-oss-prow bot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants