Skip to content

Exporting only "standard" or "experimental" ? #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dawid-nowak opened this issue Apr 17, 2025 · 3 comments · Fixed by #137
Closed

Exporting only "standard" or "experimental" ? #134

dawid-nowak opened this issue Apr 17, 2025 · 3 comments · Fixed by #137
Assignees
Labels
area/maintenance help wanted A community volunteer to work on this is wanted.
Milestone

Comments

@dawid-nowak
Copy link
Contributor

Hey;
I was wondering if it would make sense to make only "standard" apis or only "experimental" apis visible and use a Rust's features to control which set of api is exposed/available as a dependency.

The main reason is the ergonomics, I have found very often that I would import something from "standard" apis and something from "experimental" apis.

I have a PoC here:
https://github.com/kubvernor/gateway-api-rs/tree/splitting_standard_from_experimental

@shaneutt
Copy link
Member

I think that's legit. In particular, I think experimental behind a feature sounds very appropriate since its use is more rare. 👍

@shaneutt shaneutt moved this to Next in gateway-api-rs Apr 17, 2025
@shaneutt shaneutt added this to the v0.25.0 milestone Apr 17, 2025
@shaneutt shaneutt added the help wanted A community volunteer to work on this is wanted. label Apr 17, 2025
@dawid-nowak
Copy link
Contributor Author

PR created #135

@shaneutt
Copy link
Member

shaneutt commented May 8, 2025

Resolved by #137

@shaneutt shaneutt closed this as completed May 8, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in gateway-api-rs May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment