docker push on ci is not pushing with correct tags

[clux]

The GHA docker-metadata action is meant to infer tags in

controller-rs/.github/workflows/ci.yml

Lines 19 to 27 in 09ace63

	- name: Configure tags based on git tags + latest
	uses: docker/metadata-action@v4
	id: meta
	with:
	images: clux/controller
	tags: |
	type=pep440,pattern={{version}}
	type=raw,value=latest,enable={{is_default_branch}}
	type=ref,event=pr

via docker-metadata pep440.

but as can be seen in the last job it outputs:

Processing tags input
  type=pep440,pattern={{version}},prefix=otel-,value=,enable=true,priority=900
  type=ref,event=pr,prefix=otel-,enable=true,priority=600
  type=raw,value=otel,enable={{is_default_branch}},priority=200
Processing flavor input
  latest=auto
  prefix=
  prefixLatest=false
  suffix=
  suffixLatest=false
Docker image version
  otel

which means the e2e ci which is meant to test the built image from the chart fails.

I think this could be because we are not running the job in response to a tag push, but instead as a normal build.
but there's also the bad ordering setup currently: https://github.com/kube-rs/controller-rs/actions/runs/5814041092

we run docker-base which is depended on by e2e, but the e2e job does a kubectl apply on the helm output (which is always using the last version).

not sure i have enough time to fix this today and likely off for a week so rough plan:

• make e2e job do a helm template with custom values (with version set) that ensures it's the currently built image that gets tested (as opposed to either latest or the chart.yaml pin)
• figure out a way to get tag versions to get picked up by docker-metadata (tag based build)?
• figure out how e2e job works in the tag based setup? (skip?)
• possibly: combine features of base build + telemetry build and just have one docker build and get rid of docker-otel to simplify otel version selection in the chart (did a hacky _helper for it in gotpl...)
• update test doc on kube.rs with any fixes

future long term

• migrate from my personal dockerhub to kube-rs github registry
• push chart to kube-rs github registry (also oci now)

[clux]

setting ci to build on tag '*' started https://github.com/kube-rs/controller-rs/actions/runs/5825727115/job/15797966094 which actually computed correct tags
EDIT: it still didn't actually push the semver tag though wtf

[clux]

fixed tag pushes via #111.

there's a separate issue for e2e test not actually using the CI built latest tag (and instead pulls the previous :latest) because we don't have a local registry in k3s. trying to fix that in #138. to avoid confusion with all the data here that's out of date, i'll close this issue.