Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming the default Fluentd buffer PVC #1368

Closed
cbuto opened this issue Jun 21, 2023 · 1 comment · Fixed by #1443
Closed

Renaming the default Fluentd buffer PVC #1368

cbuto opened this issue Jun 21, 2023 · 1 comment · Fixed by #1443
Labels
bug Something isn't working
Milestone

Comments

@cbuto
Copy link
Contributor

cbuto commented Jun 21, 2023

Is your feature request related to a problem? Please describe.
When deploying the logging-operator in GCP using the GCP CSI driver, its possible to run into limitations due to the default name of the Fluentd buffer PVC.

Example error from the CSI driver:

...
failed to insert zonal disk: unknown Insert disk error: googleapi: Error 400: Invalid value for field 'resource.labels': ''. Label value 'logging-operator-logging-fluentd-buffer-logging-operator-logging-fluentd-0' violates format constraints. The value can only contain lowercase letters, numeric characters, underscores and dashes. The value can be at most 63 characters long. International characters are allowed., invalid
...

Unfortunately, its not possible to override this name like:

bufferStorageVolume:
  pvc:
    source:
      # update the name here
      claimName: buf
    spec:
      accessModes:
        - ReadWriteOnce
      resources:
        requests:
          storage: 10Gi
      volumeMode: Filesystem

This is because updating the claimName results in an error in the statefulset when the buffer-metrics-sidecar is enabled:

 "logging-operator-logging-fluentd-0" is invalid: spec.containers[2].volumeMounts[0].name: Not found: "logging-operator-logging-fluentd-buffer"

I believe this is because that volumeMount name is hardcoded to the default of fluentd-buffer:

Name: r.Logging.QualifiedName(v1beta1.DefaultFluentdBufferStorageVolumeName),
MountPath: bufferPath,

Describe the solution you'd like
When the fluentd.bufferStorageVolume.pvc.source.claimName name is set, the buffer metrics sidecar container should be updated to use the new volume mount name.

Describe alternatives you've considered
N/A

Additional context
Somewhat related to #1327

@pepov pepov added the bug Something isn't working label Jun 29, 2023
@pepov pepov modified the milestones: 4.x, 4.3 Jun 29, 2023
@pepov pepov modified the milestones: 4.3, 4.4 Jul 24, 2023
@cbuto
Copy link
Contributor Author

cbuto commented Aug 23, 2023

@pepov opened up #1443 with a small fix to use the proper volume mount name for the buffer metrics sidecar. let me know what you think

@kube-logging kube-logging locked and limited conversation to collaborators Aug 30, 2023
@pepov pepov converted this issue into discussion #1447 Aug 30, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants