Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret not found error not reported in Output status #1140

Open
aslafy-z opened this issue Nov 28, 2022 · 1 comment
Open

Secret not found error not reported in Output status #1140

aslafy-z opened this issue Nov 28, 2022 · 1 comment
Labels
enhancement New feature or request pinned
Milestone

Comments

@aslafy-z
Copy link
Collaborator

Describe the bug:
If an Output references a wrong or inexistent secret, the error is not reported into the Output's status.

Expected behaviour:
Output.status.active is set to false, Flow.status.active is set to false. Output should reference the error message in its status, and Flow should get, if there was a single output configured in it, status.active: false too.

Steps to reproduce the bug:

  • Create an Output that references a non existing secret.
  • Create a Flow that references the previous Output.
  • Check Output/Flow status

Environment details:

  • logging-operator version (e.g. 2.1.1): 3.17.10

/kind bug

@aslafy-z aslafy-z added the bug Something isn't working label Nov 28, 2022
@stale stale bot added the wontfix This will not be worked on label Apr 12, 2023
@pepov pepov added enhancement New feature or request and removed wontfix This will not be worked on bug Something isn't working labels Apr 12, 2023
@pepov pepov added this to the 4.2 milestone Apr 12, 2023
@stale stale bot added the wontfix This will not be worked on label Jun 12, 2023
@pepov pepov removed the wontfix This will not be worked on label Jun 12, 2023
@pepov pepov modified the milestones: 4.3, 4.x Jun 27, 2023
@stale stale bot added the wontfix This will not be worked on label Aug 26, 2023
@aslafy-z aslafy-z removed the wontfix This will not be worked on label Aug 26, 2023
@pepov pepov added the pinned label Oct 9, 2023
@pepov
Copy link
Member

pepov commented Jan 9, 2024

Idea: the validation reconciler runs after the configuration is generated so in theory we can already depend on the loggingResources variable which contains all the outputs to also register and associate the error with the given outputs and let the validation reconciler report it in the status.

@pepov pepov modified the milestones: 4.x, 4.6 Jan 9, 2024
@pepov pepov modified the milestones: 4.6, 4.7 Mar 28, 2024
mzeevi added a commit to mzeevi/container-app-operator that referenced this issue Apr 22, 2024
When a user wants logging, now automatcially SyslogNGOutput
and SyslogNGFlow objects are created. In addition, support for
Splunk has been removed and only Elasticsearch Outputs are supported.
A test case has been modified due to a known issue whiich should be
fixed in the next release of loggig-operator (kube-logging/logging-operator#1140)

Signed-off-by: mzeevi <[email protected]>
mzeevi added a commit to mzeevi/container-app-operator that referenced this issue Apr 22, 2024
When a user wants logging, now automatcially SyslogNGOutput
and SyslogNGFlow objects are created. In addition, support for
Splunk has been removed and only Elasticsearch Outputs are supported.
A test case has been modified due to a known issue whiich should be
fixed in the next release of loggig-operator (kube-logging/logging-operator#1140)

Signed-off-by: mzeevi <[email protected]>
mzeevi added a commit to mzeevi/container-app-operator that referenced this issue Apr 22, 2024
When a user wants logging, now automatcially SyslogNGOutput
and SyslogNGFlow objects are created. In addition, support for
Splunk has been removed and only Elasticsearch Outputs are supported.
A test case has been modified due to a known issue whiich should be
fixed in the next release of loggig-operator (kube-logging/logging-operator#1140)

Signed-off-by: mzeevi <[email protected]>
@pepov pepov modified the milestones: 4.7, 4.x Jun 6, 2024
@pepov pepov removed this from the 4.x milestone Oct 7, 2024
@kube-logging kube-logging deleted a comment from stale bot Nov 27, 2024
@kube-logging kube-logging deleted a comment from stale bot Nov 27, 2024
@kube-logging kube-logging deleted a comment from stale bot Nov 27, 2024
@csatib02 csatib02 added this to the Misc/Other milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
Status: No status
Development

No branches or pull requests

3 participants