Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send fluentd logs to stdout and make fluent-bit ignore them by default #1076

Closed
aslafy-z opened this issue Aug 21, 2022 · 6 comments · Fixed by #1413
Closed

Send fluentd logs to stdout and make fluent-bit ignore them by default #1076

aslafy-z opened this issue Aug 21, 2022 · 6 comments · Fixed by #1413
Labels
community enhancement New feature or request
Milestone

Comments

@aslafy-z
Copy link
Collaborator

aslafy-z commented Aug 21, 2022

Is your feature request related to a problem? Please describe.
Ease fluentd debugging

Describe the solution you'd like
To ease debugging of fluentd, send logs to stdout instead of a file.
Exclude them by default from fluent-bit collection.

Additional context
Related #1075

@stale
Copy link

stale bot commented Apr 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the wontfix This will not be worked on label Apr 12, 2023
@aslafy-z aslafy-z removed the wontfix This will not be worked on label Apr 14, 2023
@pepov
Copy link
Member

pepov commented Apr 16, 2023

What would be a good way to implement this? How about having a dedicated label for marking certain pods for fluentbit to drop their messages?

@pepov pepov added this to the 4.2 milestone Apr 16, 2023
@aslafy-z
Copy link
Collaborator Author

Fluentbit has the feature: see the K8S-Logging.Exclude option and the associated fluentbit.io/exclude annotation. I have it in production right now and its fine :)
https://docs.fluentbit.io/manual/pipeline/filters/kubernetes#kubernetes-annotations

@pepov pepov added enhancement New feature or request community labels Apr 18, 2023
@stale
Copy link

stale bot commented Jun 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the wontfix This will not be worked on label Jun 17, 2023
@aslafy-z aslafy-z removed the wontfix This will not be worked on label Jun 18, 2023
@pepov pepov modified the milestones: 4.3, 4.x Jun 27, 2023
@pepov pepov modified the milestones: 4.x, 4.3 Jul 18, 2023
@pepov
Copy link
Member

pepov commented Jul 25, 2023

Created a PR to make the fluentbit side flag enabled by default: #1395

Although this is a breaking change in theory, I don't think this would affect anyone negatively in practice. I think this is enough to introduce for now and make the changes on the fluentd side later together with improvements around the fluentd internal log handling.

@pepov
Copy link
Member

pepov commented Aug 8, 2023

This behaviour is now enabled with 4.3 and logs for fluentd and syslog-ng will be excluded by default in 4.4, so moving the issue to that milestone

@pepov pepov modified the milestones: 4.3, 4.4 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants