Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable grafana endpoint in web app #6

Open
markwinter opened this issue Jul 12, 2021 · 4 comments
Open

Configurable grafana endpoint in web app #6

markwinter opened this issue Jul 12, 2021 · 4 comments
Assignees

Comments

@markwinter
Copy link
Member

/kind feature

The web app currently seems to assume that grafana will be accessible via the same ingress as kubeflow under the path /grafana. We have a separated prometheus+grafana that we would like to use instead.

In the web app, I can see that grafanaPrefix is pulled out into the environment.ts file, but I think these vars are only read/replaced at build time and can't be overwritten at run time - I don't know Angular

I think the var needs to be read from the kfserving-models-web-app-config configMap instead? Like APP_PREFIX etc.

@kimwnasptd could you take a look please?

@markwinter
Copy link
Member Author

For now I have just created a VirtualService but I think a configurable grafana endpoint seems more correct?

@markwinter
Copy link
Member Author

markwinter commented Jul 12, 2021

It would also be helpful if the DBs were configurable too

db/knative-serving-revision-cpu-and-memory-usage
db/knative-serving-revision-http-requests

@yuzisun
Copy link
Member

yuzisun commented Jul 16, 2021

/assign @kimwnasptd

@kimwnasptd
Copy link
Contributor

@markwinter while the mechanism for allowing admins to configure different aspects of the web app, via a mounted ConfigMap, is something we want to implement I'd like to understand a little bit more your specific use case.

For now I have just created a VirtualService but I think a configurable grafana endpoint seems more correct?

You will always need to create a VirtualService to expose the Grafana instance outside the cluster. In this vsvc you can also set the prefix accordingly.

What is the limitation you are bumping into by having the web app always expect Grafana to be exposed under a /grafana prefix?

@yuzisun yuzisun transferred this issue from kserve/kserve Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants