Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signed Cloudfront URLs back for all artifacts #567

Closed
codekansas opened this issue Nov 10, 2024 · 0 comments · Fixed by #590
Closed

Add signed Cloudfront URLs back for all artifacts #567

codekansas opened this issue Nov 10, 2024 · 0 comments · Fixed by #590
Assignees

Comments

@codekansas
Copy link
Member

codekansas commented Nov 10, 2024

Currently anyone can download anything. Instead, we should return signed Cloudfront URLs from the artifact endpoint(s) (like we previously did for kernel image downloads, but which was deleted today).

Unlike the previous implementation, we want to generate the presigned Cloudfront URL instead of the S3 URL

To test this we need to add Cloudfront to localstack

@ivntsng ivntsng linked a pull request Nov 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants