From 05e2a6c5b8807672e9483d847f64ba6d4dd508be Mon Sep 17 00:00:00 2001
From: root <noah@noahstride.co.uk>
Date: Mon, 14 Mar 2022 16:05:44 +0000
Subject: [PATCH] fix: add check for valid IP address

---
 backend/api_v1/rdns.go | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/backend/api_v1/rdns.go b/backend/api_v1/rdns.go
index ff74b18..5c69ed4 100644
--- a/backend/api_v1/rdns.go
+++ b/backend/api_v1/rdns.go
@@ -16,8 +16,6 @@ type rdnsParams struct {
 
 func rdns(g group, log *zap.Logger, dnsServer string) {
 	g.GET("/:ip", func(ctx *gin.Context) {
-		ip := ctx.Param("ip")
-
 		isJson := ctx.ContentType() == "application/json"
 		var params rdnsParams
 		if err := ctx.BindQuery(&params); err != nil {
@@ -31,6 +29,19 @@ func rdns(g group, log *zap.Logger, dnsServer string) {
 			return
 		}
 
+		ip := ctx.Param("ip")
+		ipAddr := net.ParseIP(ip)
+		if ipAddr == nil {
+			if ctx.ContentType() == "application/json" {
+				ctx.JSON(400, map[string]string{
+					"message": "Provided IP is not valid",
+				})
+			} else {
+				ctx.String(400, "Provided IP is not valid")
+			}
+			return
+		}
+
 		if !params.Trace {
 			hosts, err := net.LookupAddr(ip)
 			if err != nil || len(hosts) == 0 {
@@ -54,7 +65,6 @@ func rdns(g group, log *zap.Logger, dnsServer string) {
 			return
 		}
 
-		ipAddr := net.ParseIP(ip)
 		result, err := dnsLib.LookupRDNS(
 			log, ipAddr, dnsServer,
 		)