fix: only retry when receiving a 429 status code (elastic#13523)

kruskall · web-flow · commit b6626d78661c · 2024-07-17T00:33:24.000+02:00
The only safe status code to retry is 429 because it guarantee that the
document has not been indexed. Everything else might create duplicate documents
diff --git a/internal/elasticsearch/client.go b/internal/elasticsearch/client.go
@@ -34,9 +34,6 @@ import (
 
 var retryableStatuses = []int{
 	http.StatusTooManyRequests,
-	http.StatusBadGateway,
-	http.StatusServiceUnavailable,
-	http.StatusGatewayTimeout,
 }
 
 var userAgent = fmt.Sprintf("Elastic-APM-Server/%s go-elasticsearch/%s", version.Version, esv8.Version)

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,6 @@ import (`
`34`	`34`
`35`	`35`	`var retryableStatuses = []int{`
`36`	`36`	`http.StatusTooManyRequests,`
`37`		`- http.StatusBadGateway,`
`38`		`- http.StatusServiceUnavailable,`
`39`		`- http.StatusGatewayTimeout,`
`40`	`37`	`}`
`41`	`38`
`42`	`39`	`var userAgent = fmt.Sprintf("Elastic-APM-Server/%s go-elasticsearch/%s", version.Version, esv8.Version)`