cleanup

Author: krowinski

example/benchmark.php

@@ -3,7 +3,6 @@
 namespace example;
 
 error_reporting(E_ALL);
-ini_set('display_errors', 1);
 date_default_timezone_set('UTC');
 include __DIR__ . '/../vendor/autoload.php';
 
@@ -18,6 +17,7 @@
 use MySQLReplication\Config\ConfigService;
 use MySQLReplication\Definitions\ConstEventType;
 use MySQLReplication\Event\DTO\UpdateRowsDTO;
+use SebastianBergmann\RecursionContext\InvalidArgumentException;
 
 /**
  * Class BenchmarkEventSubscribers
@@ -113,13 +113,14 @@ private function getConnection()
     /**
      * @throws MySQLReplicationException
      * @throws DBALException
+     * @throws \InvalidArgumentException
      */
     public function run()
     {
         $pid = pcntl_fork();
         if ($pid === -1)
         {
-            die('could not fork');
+            throw new \InvalidArgumentException('Could not fork');
         }
         else if ($pid)
         {
@@ -157,7 +158,6 @@ private function produce()
         }
 
         $conn->close();
-        die;
     }
 }
 

example/dump_events.php

@@ -3,7 +3,6 @@
 namespace example;
 
 error_reporting(E_ALL);
-ini_set('display_errors', 1);
 date_default_timezone_set('UTC');
 include __DIR__ . '/../vendor/autoload.php';
 
@@ -37,7 +36,7 @@ public function allEvents(EventDTO $event)
         echo $event;
 
         // all events got JsonSerializable implementation
-        //echo json_encode($result, JSON_PRETTY_PRINT);
+        echo json_encode($event, JSON_PRETTY_PRINT);
 
         echo 'Memory usage ' . round(memory_get_usage() / 1048576, 2) . ' MB' . PHP_EOL;
     }

src/MySQLReplication/BinLog/BinLogServerInfo.php

@@ -3,7 +3,6 @@
 namespace MySQLReplication\BinLog;
 
 /**
- * todo ugly class, for refactoring
  * Class BinLogServerInfo
  * @package MySQLReplication\BinLog
  */