From f678dc0484c18df3a77ba90972dbc3d211c9095c Mon Sep 17 00:00:00 2001 From: dongchangYoo Date: Mon, 18 Dec 2023 16:43:43 +0900 Subject: [PATCH] feat(zk): init `vanishing_argument` of `ProvingKey` --- tachyon/zk/plonk/keys/proving_key.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tachyon/zk/plonk/keys/proving_key.h b/tachyon/zk/plonk/keys/proving_key.h index abf8e15b60..987adb5368 100644 --- a/tachyon/zk/plonk/keys/proving_key.h +++ b/tachyon/zk/plonk/keys/proving_key.h @@ -152,9 +152,8 @@ class ProvingKey : public Key { }); l_active_row_ = domain->IFFT(evals); - // TODO(chokobole): Set |vanishing_argument_|. - // See - // https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/plonk/keygen.rs#L395. + vanishing_argument_ = + VanishingArgument::Create(verifying_key_.constraint_system()); return true; }