Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BS4 remaining #85

Open
28 of 31 tasks
kristopolous opened this issue May 26, 2020 · 12 comments
Open
28 of 31 tasks

BS4 remaining #85

kristopolous opened this issue May 26, 2020 · 12 comments

Comments

@kristopolous
Copy link
Owner

kristopolous commented May 26, 2020

BS is a large project ... there's about 8,000 lines of scss, which doesn't sound that huge, but I'm auditing all of it. The possibility of me missing a BS feature is quite high and I know they're working on BS-5 so let's make sure this thing gets done.

I don't know how on earth a front-end design project became my most popular project - I'm actually a low-level, backend and application programmer. I do really like UX though. Anyway, here we are:

Really ought to do:

  • Activating buttons should not shift content
  • There should be no space between a menu and its pulldown
  • Breadcrumbs should not look like you hit an NES bug
  • Pagination needs to look better
  • Alerts should be using the right chracter sets
  • Tabs need style
  • Selects need to look better
  • Pills need style
  • Progress bars need to not be broken
  • Popovers need to work
  • Modals need to work
  • Tooltips need to work
  • The colors on toasts are broken
  • Sliders need to be fixed
  • File upload controls need to look better
  • The braces svg needs to use the right font and be the right size
  • Table colors need to be reasonable
  • Get it to not be so fugly
  • Card headers needs to be right
  • Secondary colors need to be legible
  • button outlines shouldn't take up more horizontal space
  • h6 needs to only use the legal characters
  • tabs shouldn't overflow on mobile
  • the gray borders around buttons need to finally be correct for once.
  • tab dropdown needs to shift left ... the current offset isn't dos-possible.
  • readonly and disabled input should be using the grayLight svg variations

Maybe-do:

Punted:

  • Carousel needs to work
  • Something magnificent on mobile, it's a mess, it should be special

I'm giving myself 3 weeks to do this ... I don't know why either.

@kristopolous kristopolous changed the title BS-4 remaining BS4 remaining May 26, 2020
@spotUP
Copy link

spotUP commented May 27, 2020

awesome!

@kristopolous
Copy link
Owner Author

kristopolous commented May 28, 2020

If I get time what would be really just stunning is if the colors changed on mobile to match the old monochrome lcd screens. It's a curious and unique set of colors on these old devices. It's not just "black" and "grayish" ... It's pretty specific, and they weren't uniform, the area where content could be was a bit greener...
post-104-1146960611

@spotUP
Copy link

spotUP commented May 28, 2020

Cool idea, but please make it optional in that case. =)

@kristopolous
Copy link
Owner Author

we'll see ... if it works well I'll probably wave my dictatorial scepter and make it mandatory, this is an art project after all ... I kinda have to follow my instinct here.

@kristopolous
Copy link
Owner Author

the carousel is really the remaining piece ... I think the fugly ticket I'll have to like reformat it for a pitch page ...

Also I think I may have to add a few things to bs for the dos mode. I keep circling back to putting the primary/info/alert/warning classes on the h tags

@kristopolous
Copy link
Owner Author

also I haven't done any js yet ... probably should do that somewhere

@kristopolous
Copy link
Owner Author

i'm just going to punt the carousels, get the centering to work, package it up and ship it.

@kristopolous
Copy link
Owner Author

kristopolous commented Jun 10, 2020

Using the new features of the scrolllock and the magic cursor, the alignment issues are far easier to spot then when I was using grid.svg generated by this small nodejs script.

Ideally you'd get perfect alignment at every pixel ... there's really no reason you shouldn't be able to (well I may change this but right now that's my claim).

@spotUP
Copy link

spotUP commented Jun 14, 2020

"Ideally you'd get perfect alignment at every pixel ... there's really no reason you shouldn't be able to (well I may change this but right now that's my claim)."
*** awesome, gogogo! ***

@ser
Copy link

ser commented Sep 23, 2021

Now just quickly update it for 5.1 🥇

@kristopolous
Copy link
Owner Author

kristopolous commented Jul 31, 2023

Now just quickly update it for 5.1 1st_place_medal

HAHAHAHA

I have to rewrite it from scratch every version. It's not just simple colors constants and fonts - it's massive overhauls. This isn't really a "theme", it's a proper fork. I'll work on it though.

@EvanCarroll
Copy link

Any progress 28/31, we nearing a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants