Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim9 script implementation of the indent script #27

Open
dkearns opened this issue Nov 5, 2022 · 5 comments
Open

Vim9 script implementation of the indent script #27

dkearns opened this issue Nov 5, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@dkearns
Copy link

dkearns commented Nov 5, 2022

Translating the indent script to Vim9 script appears to give an at least three fold improvement in performance. Given that indenting is generally slow this is an appreciable improvement when reindenting large files.

Neovim doesn't currently support Vim9 script. There is some work progressing in this area but it's still unclear whether it will eventually be merged. So both the legacy and Vim9 versions would need to be included to support both editors.

Would you be interested in including a Vim9 script version either as a replacement for or alongside the current legacy script version?

@krischik krischik added the enhancement New feature or request label Nov 5, 2022
@krischik
Copy link
Owner

krischik commented Nov 7, 2022

I recently learned that NeoVim has support for Language Server Protocol which is an advantage for Ada (using Ada Language Server). So dropping NeoVim might not be an option. Mind you the Alire version of GNAT comes without gnatprove so ALS probably only works for Gnat-Pro users.

@TamaMcGlinn
Copy link

No, ALS doesn't need gnatprove. And gnatprove is also available in community GNAT.

@krischik
Copy link
Owner

krischik commented Nov 9, 2022

But the community GNAT has been deprecated in favour of Alire. Understandable as Alire is very easy to install and use. But no gnatprove and no gnatpp:

>la ~/.config/alire/cache/dependencies/gnat_native_12.1.2_587b912f/bin 
total 160208
drwxr-xr-x  32 martin  staff  -  1,0K 17 Jul 19:54 ./
drwxr-xr-x   9 martin  staff  -  288B 19 Okt 17:58 ../
-rwxr-xr-x   1 martin  staff  -  1,3M 17 Jul 19:41 c++
-rwxr-xr-x   1 martin  staff  -  1,3M 17 Jul 19:41 cpp
-rwxr-xr-x   1 martin  staff  -  1,3M 17 Jul 19:41 g++
-rwxr-xr-x   1 martin  staff  -  1,3M 17 Jul 19:41 gcc
-rwxr-xr-x   1 martin  staff  -   52K 17 Jul 19:41 gcc-ar
-rwxr-xr-x   1 martin  staff  -   52K 17 Jul 19:41 gcc-nm
-rwxr-xr-x   1 martin  staff  -   52K 17 Jul 19:41 gcc-ranlib
-rwxr-xr-x   1 martin  staff  -  939K 17 Jul 19:41 gcov
-rwxr-xr-x   1 martin  staff  -  624K 17 Jul 19:41 gcov-dump
-rwxr-xr-x   1 martin  staff  -  641K 17 Jul 19:41 gcov-tool
-rwxr-xr-x   1 martin  staff  -   13M 17 Jul 19:54 gdb
-rwxr-xr-x   1 martin  staff  -  4,5K 17 Jul 19:54 gdb-add-index
-rwxr-xr-x   1 martin  staff  -  1,0M 17 Jul 19:41 gnat
-rwxr-xr-x   1 martin  staff  -  2,5M 17 Jul 19:41 gnatbind
-rwxr-xr-x   1 martin  staff  -  1,4M 17 Jul 19:41 gnatchop
-rwxr-xr-x   1 martin  staff  -  2,4M 17 Jul 19:41 gnatclean
-rwxr-xr-x   1 martin  staff  -  940K 17 Jul 19:41 gnatkr
-rwxr-xr-x   1 martin  staff  -  1,1M 17 Jul 19:41 gnatlink
-rwxr-xr-x   1 martin  staff  -  2,6M 17 Jul 19:41 gnatls
-rwxr-xr-x   1 martin  staff  -  2,9M 17 Jul 19:41 gnatmake
-rwxr-xr-x   1 martin  staff  -  2,3M 17 Jul 19:41 gnatname
-rwxr-xr-x   1 martin  staff  -  2,5M 17 Jul 19:41 gnatprep
-rwxr-xr-x   1 martin  staff  -   32M 17 Jul 19:41 lto-dump
-rwxr-xr-x   1 martin  staff  -  1,3M 17 Jul 19:41 x86_64-apple-darwin19.6.0-c++
-rwxr-xr-x   1 martin  staff  -  1,3M 17 Jul 19:41 x86_64-apple-darwin19.6.0-g++
-rwxr-xr-x   1 martin  staff  -  1,3M 17 Jul 19:41 x86_64-apple-darwin19.6.0-gcc
-rwxr-xr-x   1 martin  staff  -  1,3M 17 Jul 19:41 x86_64-apple-darwin19.6.0-gcc-12.1.0
-rwxr-xr-x   1 martin  staff  -   52K 17 Jul 19:41 x86_64-apple-darwin19.6.0-gcc-ar
-rwxr-xr-x   1 martin  staff  -   52K 17 Jul 19:41 x86_64-apple-darwin19.6.0-gcc-nm
-rwxr-xr-x   1 martin  staff  -   52K 17 Jul 19:41 x86_64-apple-darwin19.6.0-gcc-ranlib

which is a bit of a bummer.

@TamaMcGlinn
Copy link

but you are assuming the omission was on purpose? It seems like a mistake to me, my understanding was that the alire crate was meant to just copy all of a normal GNAT installation; shall we see if they accept a PR to add them back in?

@krischik
Copy link
Owner

krischik commented Nov 9, 2022

Didn't assume anything. Just observed. Speaking of observing: Just noticed right after hitting send that alr gnatprove does something. Maybe only the executable is missing but the functionality is still somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants