Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get Binance and Coinbase Pro to work in example sheet #86

Open
kbfifi opened this issue Nov 22, 2021 · 2 comments
Open

Cannot get Binance and Coinbase Pro to work in example sheet #86

kbfifi opened this issue Nov 22, 2021 · 2 comments

Comments

@kbfifi
Copy link

kbfifi commented Nov 22, 2021

Hello Koen,

Great project! I tried the example sheet and created API keys for Binance and CoinbasePro.

Question:
I still do not understand the sheets: How do they get triggered? What causes the sheet content to be updated? I clearly miss the point.

Issue 1:
So I tried the corresponding test functions:
Ran TestBinance with F5:
-Test.IsOk JsonResult("balances").Count > 10, "test Private GET 1g failed, result: ${1}"
results in "Run time error 424, object required"

Issue 2:
Ran TestCoinbasePro with F5:
-Test.IsEqual JsonResult(1)("currency"), "BAT"
results in "Run time error 13, Type mismatch"

Any suggestions? Really like it to work. I'm using Office Professional Plus 2016.

@kbfifi
Copy link
Author

kbfifi commented Nov 23, 2021

Ok, spent a little more time on this and got the example sheets for Binance and Coinbase Pro to work. The Binance example code in the sheet is outdated and not in sync with the test function. "account" = > "/api/v3/account"

Besides that I think if the examples would contain a button that triggers the example code it would be more self-explanatory.

@krijnsent
Copy link
Owner

Hi @kbfifi ,
thanks for your feedback. I have considered builing a more full fledged tool with buttons etc, but decided in the end to just provide the basic building blocks. So yeah, my code is for some more experienced VBA users and I'm glad you're now one of them ;-). Secondly: I know I should update my exchanges, some are a bit outdated now, but my startup is taking up all my time and I'm not a trader myself, so don't use my own code that much.
Cheers,
Koen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants