Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If incoming sysex is just "F0 F7" with no data, file is created, but shows error message and isn't added to library #84

Open
krevis opened this issue Jan 24, 2021 · 0 comments

Comments

@krevis
Copy link
Owner

krevis commented Jan 24, 2021

Have a user with a no-name USB-MIDI cable which appears to be dropping sysex data. We're getting only F0 F7 but with no data inside.

When this happens, we save the .syx file (containing one or more iterations of F0 F7). However when we go to read in the contents of that file, we are hitting an error path, and show an alert that "The file could not be created".

Either we should filter out sysex messages with no contents earlier in the recording path, or we should treat these zero-contents messages as being allowable. Probably the former. Perhaps tell the user when we get them, if this is a common enough thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant