Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keybinding doesn't work on Firefox OSX #17

Open
thomasd3 opened this issue Jan 3, 2020 · 1 comment
Open

keybinding doesn't work on Firefox OSX #17

thomasd3 opened this issue Jan 3, 2020 · 1 comment

Comments

@thomasd3
Copy link

thomasd3 commented Jan 3, 2020

Ctrl-Alt-B doesn't do anything on Firefox OSX.

Safari works properly, on the same machine.

Additionally, how does one change the key binding? the doc says it's possible, but there is not example of syntax and the config file doesn't have one either.

@krassowski
Copy link
Owner

Thank you for reporting this issue. Mac has a different mapping of modifiers to the physical keys which may (or may not) be interpreted differently between browsers. This table with modifiers mapping depending on OS comes from the authors of Firefox, so I would hope that it may be helpful.

Unfortunately, I do not have a Mac to test it, but I will welcome any PRs fixing this issue.

I think that it is currently only possible to change the modifier key for mouse action:
go_to_definition_change_hotkey
If there is a documentation fragment saying otherwise, please do let me know (or send a PR).

However, using jupyterlab-lsp it is also possible to change the keyboard hotkey:
Screenshot from 2020-01-05 00-02-38

jupyterlab-lsp improves the functionality of jupyterlab-go-to-definition, and I may end up recommending it to everyone one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants