Skip to content

Dynamically load libnetfilter.so so that applications who use the library will load on all systems. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arunmk opened this issue Jul 21, 2015 · 4 comments

Comments

@arunmk
Copy link

arunmk commented Jul 21, 2015

We should be able to use the library even on systems where libnetfilter is not available. There must be a way to check if we can use libnetfilter, and if we cannot, we should be able to gracefully handle the situation.
With the current implementation, a binary using this library will fail while loading.

@arunmk
Copy link
Author

arunmk commented Jul 21, 2015

This will be fixed by pull: #6

@arunmk
Copy link
Author

arunmk commented Jul 21, 2015

@kraman please advise if I should do anything else. I have run a few tests on my machine with this change.

@kraman
Copy link
Owner

kraman commented Jul 22, 2015

@arunmk thanks for the PR, do you mind sending your tests as well, I have been meaning to add tests to this repo.

@arunmk
Copy link
Author

arunmk commented Jul 22, 2015

@kraman sorry I was unclear about the tests. These have been manual tests with a debugger. I can create a few tests as a new PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants