Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confit convert number to string #72

Open
Nemek opened this issue Jul 19, 2017 · 1 comment
Open

Confit convert number to string #72

Nemek opened this issue Jul 19, 2017 · 1 comment

Comments

@Nemek
Copy link

Nemek commented Jul 19, 2017

Hi,

after a change from 2.1.0 to 2.2.1 we found out that somehow a breaking change occured.
We have this object in our config.json (kraken)

    "cookies": {
      "expires": 0,
      "secure": false,
      "signed": true
    }

In 2.1.0 after using:
config.get('cookies')
we received: { expires: 0, secure: false, signed: true }

but in 2.2.1 we got:
{ expires: '0', secure: false, signed: true }

Please take a look at this issue, unfortunately kraken-js is taking all non-breaking changes from confit and it has impact on our project.

@lcalvy
Copy link

lcalvy commented Aug 22, 2017

Confirmed that it breaks expressjs setting like 'json spaces' giving this kind of json response output du to "0" in place of 0:

{
0"splitDiscussionsByLang": true,
0"hideFooter": false,
0"maxSlidePerChapter": 3,
0"maxSlidePerChapterBattle": 2,
0"maxTyposForSlides": 2,
0"maxShots": 3,
0"maxStars": 2000,
0"badgesLimits": {
00"battle": [
0003,
00010,
00025,
00050
00],
00"coach": [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants