Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to style Dialog instances using inline styles #57

Open
ivmarkov opened this issue Nov 22, 2017 · 1 comment
Open

Ability to style Dialog instances using inline styles #57

ivmarkov opened this issue Nov 22, 2017 · 1 comment
Assignees

Comments

@ivmarkov
Copy link

ivmarkov commented Nov 22, 2017

Looking at code https://github.com/kradio3/react-mdc-web/blob/master/src/Dialog/Dialog.js
line 63, "... otherProps" seem to be placed on the <aside> element.

Is this really useful? What other properties would the user want to put on the aside element?

If we would like to e.g. style the Dialog with min-width/min-height, we currently cannot do this as these do not have the desired effect when put on the <aside> element. Shouldn't you assign "...otherProps" on the <div> element starting on line 65 instead?

@kradio3
Copy link
Owner

kradio3 commented Nov 23, 2017

You right, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants