You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this really useful? What other properties would the user want to put on the aside element?
If we would like to e.g. style the Dialog with min-width/min-height, we currently cannot do this as these do not have the desired effect when put on the <aside> element. Shouldn't you assign "...otherProps" on the <div> element starting on line 65 instead?
The text was updated successfully, but these errors were encountered:
Looking at code https://github.com/kradio3/react-mdc-web/blob/master/src/Dialog/Dialog.js
line 63, "... otherProps" seem to be placed on the
<aside>
element.Is this really useful? What other properties would the user want to put on the aside element?
If we would like to e.g. style the Dialog with min-width/min-height, we currently cannot do this as these do not have the desired effect when put on the
<aside>
element. Shouldn't you assign "...otherProps" on the<div>
element starting on line 65 instead?The text was updated successfully, but these errors were encountered: