Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrepareBias is really hard to use #44

Open
kpu opened this issue Nov 29, 2019 · 3 comments
Open

PrepareBias is really hard to use #44

kpu opened this issue Nov 29, 2019 · 3 comments
Assignees
@XapaJIaMnu

Comments

@kpu
Copy link
Owner

kpu commented Nov 29, 2019 •
edited
Loading

If there's only one choice of Callback, don't make it a template argument. Why would anybody want to provide something other than 1?
@kpu
Copy link
Owner Author

kpu commented Nov 30, 2019

Also this shouldn't depend on the number of rows in A, right?

@XapaJIaMnu
Copy link
Collaborator

So, I saw you fixed it already. Question: We only support Biases that are the shape 1xcolsB. We do not support biases that are the full shape of the C matrix, like BLAS?

@kpu
Copy link
Owner Author

kpu commented Dec 1, 2019

I guess it is called intgemm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XapaJIaMnu XapaJIaMnu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kpu @XapaJIaMnu