KB-225-Block-campus-functionality-if-student-not-signed-Code-of-Honor #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markusplay
changed the title
niravzi
requested changes
Jan 30, 2025
| const t = await getTranslations('global.menu'); | ||
| const user = await getUserDetails(); | ||
|
|
||
| if (!user?.codeOfHonorSignDate && !!user?.studentProfile) { |
There was a problem hiding this comment.
Let's try to move this logic to middleware and create a separate page with this dialog.
| </AlertDialogHeader> | ||
| <AlertDialogFooter> | ||
| <Link href="/"> | ||
| <AlertDialogCancel>{t('button.go-to-home')}</AlertDialogCancel> |
There was a problem hiding this comment.
No cancel option. Only sign.
…not-signed-Code-of-Honor # Conflicts: # src/app/[locale]/(private)/profile/profile.tsx
…not-signed-Code-of-Honor # Conflicts: # src/app/[locale]/(private)/profile/profile.tsx
…y-if-student-not-signed-Code-of-Honor' into KB-225-Block-campus-functionality-if-student-not-signed-Code-of-Honor
niravzi
requested changes
Feb 4, 2025
src/middleware.ts
Outdated
| @@ -90,5 +112,10 @@ export async function middleware(request: NextRequest) { | |||
| return intlMiddleware(request); | |||
| } | |||
|
|
|||
| const honorRedirect = await CoHMiddleware(request); | |||
There was a problem hiding this comment.
Why are you checking code of honor before checking that user is authenticated?
src/middleware.ts
Outdated
| @@ -76,8 +80,26 @@ const authMiddleware = (request: NextRequest) => { | |||
| return intlMiddleware(request); | |||
| }; | |||
|
|
|||
| const CoHMiddleware = async (request: NextRequest) => { | |||
There was a problem hiding this comment.
Why shortened page path? accept-code-of-honor is ok IMO
| const [, setUser] = useLocalStorage<User>('user'); | ||
|
|
||
| const handleAcceptCodeOfHonor = async () => { | ||
| const res = await acceptCodeOfHonor(); |
There was a problem hiding this comment.
We do not utilize sign date stored in localStorage, and besides that we're planning to get rid of localStorage usage anyways. So I think we don't need to re-request user details here and store user in localStorage after signing code of honor.
src/middleware.ts
Outdated
| @@ -32,6 +35,7 @@ const publicPathRegExp = composePathsRegExp([ | |||
| const isRoot = (request: NextRequest) => rootRegExp.test(request.nextUrl.pathname); | |||
| const isPublicPath = (request: NextRequest) => publicPathRegExp.test(request.nextUrl.pathname); | |||
| const isAuthPath = (request: NextRequest) => authPathRegExp.test(request.nextUrl.pathname); | |||
| const isAcceptHonorPath = (request: NextRequest) => honorPageRegExp.test(request.nextUrl.pathname); | |||
There was a problem hiding this comment.
Also a bit inconsistent naming. isAcceptCodeOfHonorPath
niravzi
approved these changes
Feb 7, 2025
niravzi
deleted the
KB-225-Block-campus-functionality-if-student-not-signed-Code-of-Honor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.