From b49d3fe32e78352c8a8cd0c9247e214d862dae0c Mon Sep 17 00:00:00 2001 From: Kory Draughn Date: Mon, 16 Dec 2024 16:18:31 -0500 Subject: [PATCH] squash w/ [3902] Replace GenQuery1 ad-hoc parsing code with flex/bison parser. Expand comment about generation of queries file. --- unit_tests/src/test_genquery1_flex_bison_parser.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/unit_tests/src/test_genquery1_flex_bison_parser.cpp b/unit_tests/src/test_genquery1_flex_bison_parser.cpp index 7177443025..91c542c429 100644 --- a/unit_tests/src/test_genquery1_flex_bison_parser.cpp +++ b/unit_tests/src/test_genquery1_flex_bison_parser.cpp @@ -33,7 +33,13 @@ TEST_CASE("GenQuery1 flex bison parser maintains backward compatibility with ori // input struct. // Open file containing list of GenQuery1 query strings. This list of queries was - // produced from the test suite. + // generated from the unit and core test suites using the following steps: + // + // 1. Modify fillGenQueryInpFromStrCond() so that it appends each query string to a local file. + // The file is written to a directory which is automatically captured by the testing + // environment (e.g. /var/log/irods). + // 2. If the tests were run in parallel, take each file (now stored on the host) and concatenate them. + // 3. Clean up file contents (i.e. dedup lines, etc). const auto file_path = irods::get_irods_home_directory() / "unit_tests/genquery1_backwards_compatibility_queries.txt"; std::ifstream in{file_path.generic_string()}; REQUIRE(in); @@ -429,4 +435,4 @@ auto separateSelFuncFromAttr(char* t, char** aggOp, char** colNm) -> int } *s = '\0'; return 0; -} +} // separateSelFuncFromAttr