Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reserved gradle.properties more explicit #42

Open
SerVB opened this issue Jan 2, 2021 · 0 comments
Open

Make reserved gradle.properties more explicit #42

SerVB opened this issue Jan 2, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@SerVB
Copy link

SerVB commented Jan 2, 2021

In the discussion, it turns out that there are some Gradle properties that KorGE Gradke plugin uses implicitly.

I haven't been aware of that and made a constant korgeVersion=2.0.0.2 to pass it to the version of plugin, but it was used for version of KorGE lib too, so it crashed the build as KorGE lib versioning differs from KorGE Gradle plugin versioning.

I think this should be made more explicit. So there are two proposals:

  1. Document which constants are used by KorGE Gradle plugin.
  2. Make KorGE Gradle plugin output to build log if it finds and uses overridden versions instead of predefined ones.
@soywiz soywiz added the documentation Improvements or additions to documentation label Jan 2, 2021
@soywiz soywiz transferred this issue from korlibs/korge Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Pending
Development

No branches or pull requests

2 participants